-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: ignore Storybook stories in CodeCov #13421
Conversation
@ktmud some stories have |
1fe0cd8
to
f4a1df6
Compare
@michael-s-molina These warnings only show up when you modify a file. I was hoping the next time we touch a |
I didn't know that the warnings only show when we modify.. in that case we should be fine 😁 |
Hum.. thinking a little more about it.. we have the case of executing the coverage script through npm.. in that case it will count .jsx stories. What do you think @ktmud ? |
Yeah, it could have an impact on coverage percentages, but should not throw the warnings. So I'm adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thanks!
SUMMARY
Ignore Storybook stories in CodeCov report so we don't get these unnecessary warnings:
Stories are a type of visual tests themselves and do not normally need test coverage.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI
ADDITIONAL INFORMATION