test: Adds storybook to SearchInput component #13410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13410 +/- ##
==========================================
- Coverage 76.33% 73.44% -2.89%
==========================================
Files 900 606 -294
Lines 45596 21263 -24333
Branches 5491 5436 -55
==========================================
- Hits 34804 15617 -19187
+ Misses 10648 5519 -5129
+ Partials 144 127 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Mar 3, 2021
superset-frontend/src/components/SearchInput/SearchInput.stories.tsx
Outdated
Show resolved
Hide resolved
rusackas
reviewed
Mar 3, 2021
| }: SearchInputProps) => { | ||
| const [currentValue, setCurrentValue] = useState(value); | ||
| return ( | ||
| <div style={{ width: 230 }}> |
There was a problem hiding this comment.
Just a curiosity - 230 seems... specific. Is there a reason for that, e.g. a layout feature (full-width, etc) that should be tweakable or demonstrated by the story?
There was a problem hiding this comment.
Not really, it's just to look more beautiful when viewing the story. The story host takes full width and I don't want the Select to stretch 😉.
rusackas
approved these changes
Mar 3, 2021
Co-authored-by: Evan Rusackas <[email protected]>
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* test: Adds storybook to SearchInput component * Fixes placeholder text Co-authored-by: Evan Rusackas <[email protected]> Co-authored-by: Evan Rusackas <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
SearchInputcomponentSearchInputtests to component's folderTEST PLAN
1 - Execute
SearchInputtests2 - All tests should pass
@rusackas
ADDITIONAL INFORMATION