chore: improve modal error handling #13342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilykuang
force-pushed
the
lily/improve-error-handling
branch
from
1a53687 to
a866218
Compare
nytai
approved these changes
Mar 15, 2021
Comment on lines
+621
to
+622
| body: JSON.stringify(connection), | ||
| headers: { 'Content-Type': 'application/json' }, |
There was a problem hiding this comment.
nit: you can use 'postPayload with a js object, instead of body + json header
lilykuang
force-pushed
the
lily/improve-error-handling
branch
from
a866218 to
5a4dcc6
Compare
Codecov Report
@@ Coverage Diff @@
## master #13342 +/- ##
==========================================
- Coverage 77.35% 73.03% -4.33%
==========================================
Files 918 608 -310
Lines 46652 21644 -25008
Branches 5723 5640 -83
==========================================
- Hits 36087 15807 -20280
+ Misses 10429 5701 -4728
Partials 136 136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* improve modal error handling * update hook to handle string error message
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
Add Dataset Modal
https://www.loom.com/share/917e800b537045c6a06be429cfe8835e
Database Modal
https://www.loom.com/share/cfe90327bde649d186b66260bf0814c7
TEST PLAN
ADDITIONAL INFORMATION