Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves OnPasteSelect tests to component's folder #13338

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Moves OnPasteSelect tests to component's folder
  • Renames SupersetStyledSelect to Select
  • Disables knobs in Storybook

@rusackas I have not added any tests for Select now because we must migrate this component to AntD. I will do it as part of the migration process.

TEST PLAN

1 - Execute OnPasteSelect tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #13338 (8a4648f) into master (d39bc14) will increase coverage by 0.43%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13338      +/-   ##
==========================================
+ Coverage   72.26%   72.69%   +0.43%     
==========================================
  Files         876      576     -300     
  Lines       45409    21021   -24388     
  Branches     5440     5440              
==========================================
- Hits        32815    15282   -17533     
+ Misses      12384     5616    -6768     
+ Partials      210      123      -87     
Flag Coverage Δ
cypress 58.17% <ø> (?)
hive ?
javascript 62.26% <60.00%> (-0.01%) ⬇️
mysql ?
postgres ?
presto ?
python ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/Select/Select.stories.tsx 0.00% <0.00%> (ø)
superset-frontend/src/components/Select/Select.tsx 90.81% <ø> (ø)
superset-frontend/src/components/Select/styles.tsx 86.30% <ø> (+24.65%) ⬆️
superset-frontend/src/components/Select/index.ts 100.00% <100.00%> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 92.85% <100.00%> (+7.14%) ⬆️
...rset-frontend/src/explore/components/SaveModal.tsx 91.20% <100.00%> (+4.39%) ⬆️
superset-frontend/src/views/routes.tsx 56.81% <0.00%> (-6.82%) ⬇️
...rontend/src/explore/components/DatasourcePanel.tsx 76.00% <0.00%> (-3.17%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 84.33% <0.00%> (-1.03%) ⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 62.50% <0.00%> (-0.66%) ⬇️
... and 509 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d39bc14...681cd2a. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 19c8a62 into apache:master Mar 1, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants