Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrating some LESS to Emotions for ResultSet components #13296

Merged
merged 1 commit into from
Feb 25, 2021
Merged

chore: migrating some LESS to Emotions for ResultSet components #13296

merged 1 commit into from
Feb 25, 2021

Conversation

rusackas
Copy link
Member

SUMMARY

Just a small handful of styles I noticed while touching the .ResultSetButtons class in #13254. This just moves a few lines out of LESS and into Emotion styled components using gridUnit. I was on the fence about using the css prop vs the styled approach, but went with the latter since if we're to open a hundred of these PRs, I figured it makes sense to go with the one that's easier to review, by migrating a unique class to a unique styled component. If others prefer the css approach, I'll re-jigger this one, and follow that pattern going forward.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Passes CI and nobody can tell I did anything at all ;)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

kgabryje
kgabryje approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkdotson
pkdotson approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less Less is always good!

@junlincc junlincc added the frontend:refactor Related to refactoring the frontend label Feb 23, 2021
@pkdotson pkdotson merged commit 33bec57 into apache:master Feb 25, 2021
@pkdotson pkdotson deleted the migrating-ResultSet-LESS branch February 25, 2021 23:45
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@rusackas
chore: migrating some LESS (apache#13296)
9043a6e
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@pkdotson pkdotson pkdotson approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels frontend:refactor Related to refactoring the frontend preset-io size/M 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rusackas @kgabryje @pkdotson @mistercrunch @junlincc