chore: Migrates RefreshChartOverlay into Chart

[michael-s-molina]

SUMMARY

Migrates RefreshChartOverlay into Chart.

RefreshChartOverlay wasn't used anywhere outside Chart and it's a specific behavior of the chart component. Also, most of its properties weren’t being used.

TEST PLAN

1 - Execute Chart tests
2 - All tests should pass

@rusackas

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #13274 (e44a437) into master (1e3130d) will decrease coverage by 4.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #13274      +/-   ##
==========================================
- Coverage   77.04%   72.67%   -4.38%     
==========================================
  Files         894      593     -301     
  Lines       45664    21237   -24427     
  Branches     5490     5489       -1     
==========================================
- Hits        35184    15433   -19751     
+ Misses      10356     5680    -4676     
  Partials      124      124              

Flag	Coverage Δ
cypress	57.63% <100.00%> (+<0.01%)	⬆️
hive	?
javascript	62.40% <50.00%> (+<0.01%)	⬆️
mysql	?
postgres	?
presto	?
python	?
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/chart/Chart.jsx	64.81% <100.00%> (+0.66%)	⬆️
...set-frontend/src/dashboard/util/getDropPosition.js	90.90% <0.00%> (ø)
superset/views/base_api.py
superset/reports/dao.py
superset/common/query_context.py
superset/extensions.py
superset/queries/saved_queries/api.py
superset/annotation_layers/commands/delete.py
superset/db_engine_specs/mysql.py
superset/annotation_layers/commands/bulk_delete.py
... and 292 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3130d...441f182. Read the comment docs.

[junlincc]

added test:component label to track project, but not actually related. Thanks for the PR and review @michael-s-molina @geido 🙏

[michael-s-molina]

@rusackas It seems that the Cypress error in explore/control.test.ts is not related to this PR or maybe it's not even an error but the random nature of some tests 😆.

It executes successfully locally:

I probably spammed reviewers' emails with forced pushes or open/close trying to make this pass (sorry about that). Maybe you are luckier than me? Or maybe it's an error and I'm low on coffee 😩?

[michael-s-molina]

I finally found out what was causing the test to fail. Although width was no longer used in Chart, it was used in ChartRenderer and therefore could not be removed from ChartContainer. Turns out it was the lack of coffee 😬

[rusackas]

LGTM! Just needs a rebase to merge.