Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix when there's only date filter in FilterBox #1326

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Bugfix when there's only date filter in FilterBox #1326

merged 1 commit into from
Oct 12, 2016

Conversation

yejianye
Copy link
Contributor

To reproduce the bug

  • Create a new slice with Filter Box type
  • Turn on 'Date Filter' and leave 'Filter fields' empty
  • Save the slice and add it to a dashboard
  • Go to that dashboard, and you will get an 500 server error.

The problem is that groupby field has a default value to None. So when Filter fields is empty, It breaks code in FilterBoxViz.query_obj and FilterBoxViz.get_data, as well as filterBox.refresh in filter_box.jsx. Set default value to [] solves the problem.

@mistercrunch mistercrunch merged commit 4cf4e38 into apache:master Oct 12, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@stephenLYZ @zhaoyongjie
fix(plugin-chart-echarts): [guage chart] filter indicator not shown (a…
73a510d 
…pache#1326)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@stephenLYZ @zhaoyongjie
fix(plugin-chart-echarts): [guage chart] filter indicator not shown (a…
47d4ea9 
…pache#1326)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@stephenLYZ @zhaoyongjie
fix(plugin-chart-echarts): [guage chart] filter indicator not shown (a…
12bd8f6 
…pache#1326)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@stephenLYZ @zhaoyongjie
fix(plugin-chart-echarts): [guage chart] filter indicator not shown (a…
6b1b142 
…pache#1326)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yejianye @mistercrunch