Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Evaluate configOverrides as templates #13130

Merged
merged 1 commit into from
Feb 18, 2021
Merged

feat(helm): Evaluate configOverrides as templates #13130

merged 1 commit into from
Feb 18, 2021

Conversation

Yann-J
Copy link
Contributor

@Yann-J Yann-J commented Feb 15, 2021

SUMMARY

This change will evaluate configOverrides as templates. This allows making those overrides dynamic and use input values from values.yaml which may not be easy to ingest as env variables. For instance:

configOverrides:
   reports: |
    WEBDRIVER_BASEURL = "http://{{ template "superset.fullname" . }}:{{ .Values.service.port }}/"

TEST PLAN

  • Update your values.yaml with some values based on Helm values - see example above
  • helm upgrade your chart release

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the new:contributor The author is a new contributor label Feb 15, 2021
@dpgaspar dpgaspar requested a review from craig-rueda February 15, 2021 18:04
@Yann-J
Copy link
Contributor Author

Yann-J commented Feb 17, 2021

Hi there @craig-rueda just a quick ping on that last Helm-related PR from my side... This one was a bit of a leftover from the previous one on config overrides, and should be very safe to merge...

@craig-rueda craig-rueda merged commit 1e17ef3 into apache:master Feb 18, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels new:contributor The author is a new contributor size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants