fix: API tests, make them possible to run independently again #13076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
dpgaspar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13076 +/- ##
===========================================
+ Coverage 53.06% 66.88% +13.82%
===========================================
Files 489 490 +1
Lines 17314 28856 +11542
Branches 4482 0 -4482
===========================================
+ Hits 9187 19301 +10114
- Misses 8127 9555 +1428
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbarrett
approved these changes
Feb 11, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
…#13076) * fix: API tests, possible to run independently * fix workflow name
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
* master: (30 commits) refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021) fix(native-filters): set currentValue null when empty (apache#13000) Custom superset_config.py + secret envs (apache#13096) Update http error code from 400 to 403 (apache#13061) feat(native-filters): add storybook entry for select filter (apache#13005) feat(native-filters): Time native filter (apache#12992) Force pod restart on config changes (apache#13056) feat(cross-filters): add cross filters (apache#12662) fix(explore): Enable selecting an option not included in suggestions (apache#13029) Improves RTL configuration (apache#13079) Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083) chore: lock down npm to v6 (apache#13069) fix: API tests, make them possible to run independently again (apache#13076) fix: add config to disable dataset ownership on the old api (apache#13051) add required * indicator to message content/notif method (apache#12931) fix: Retroactively add granularity param to charts (apache#12960) fix(ci): multiline regex in change detection (apache#13075) feat(style): hide dashboard header by url parameter (apache#12918) fix(explore): pie chart label bugs (apache#13052) fix: Disabled state button transition time (apache#13008) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Quick fix to make it possible again to run API tests independently
Tested with:
./scripts/tests/run.sh --module tests/annotation_layers/api_tests.py./scripts/tests/run.sh --module tests/charts/api_tests.py./scripts/tests/run.sh --module tests/css_templates/api_tests.py./scripts/tests/run.sh --module tests/dashboards/api_tests.py./scripts/tests/run.sh --module tests/databases/api_tests.py./scripts/tests/run.sh --module tests/reports/api_tests.pyUnfortunately datasets tests still depend on uncleaned data from other tests (difficult to pin), I'll address this problem on a separate PR
TEST PLAN
Run API tests independently
ADDITIONAL INFORMATION