Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sort_by_metric for charts with single metric #13058

Merged
merged 11 commits into from
Feb 15, 2021

Conversation

maloun96
Copy link
Contributor

@maloun96 maloun96 commented Feb 10, 2021

SUMMARY

Add sort_by_metric flag for charts with single metric

Related: #12674

After

legacy-plugin-chart-heatmap

heatmap

legacy-plugin-chart-sunburst

sunburst

legacy-plugin-chart-force-directed

force-directed

legacy-plugin-chart-chord

chod

legacy-plugin-world-map

country-map

ADDITIONAL INFORMATION

@maloun96 maloun96 changed the title Single metric sort feat: Single metric sort Feb 10, 2021
@junlincc junlincc requested a review from villebro February 11, 2021 02:48
@junlincc junlincc added the explore:sort Related to sorting in Explore label Feb 11, 2021
@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #13058 (7e661e1) into master (2ce7982) will increase coverage by 13.61%.
The diff coverage is 24.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13058       +/-   ##
===========================================
+ Coverage   53.06%   66.68%   +13.61%     
===========================================
  Files         489      491        +2     
  Lines       17314    28944    +11630     
  Branches     4482        0     -4482     
===========================================
+ Hits         9187    19300    +10113     
- Misses       8127     9644     +1517     
Flag Coverage Δ
cypress ?
python 66.68% <24.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/birth_names.py 73.19% <ø> (ø)
...43f2fdb_add_granularity_to_charts_where_missing.py 0.00% <0.00%> (ø)
...s/260bf0649a77_migrate_x_dateunit_in_time_range.py 0.00% <0.00%> (ø)
...ons/versions/41ce8799acc3_rename_pie_label_type.py 0.00% <0.00%> (ø)
superset/connectors/sqla/views.py 62.43% <4.34%> (ø)
superset/views/datasource.py 88.70% <16.66%> (ø)
superset/viz.py 58.82% <20.00%> (ø)
superset/utils/core.py 87.63% <66.66%> (ø)
superset/charts/commands/exceptions.py 92.85% <77.77%> (ø)
superset/db_engine_specs/elasticsearch.py 89.74% <93.75%> (ø)
... and 945 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956f276...7e661e1. Read the comment docs.

@junlincc
Copy link
Member

@maloun96 thanks for the PR and dedicated work, Victor! when I pulled for testing, changes are not showing, did I miss something?

@maloun96
Copy link
Contributor Author

@maloun96 thanks for the PR and dedicated work, Victor! when I pulled for testing, changes are not showing, did I miss something?

@junlincc You have to link locally all the plugins with npm link

@junlincc
Copy link
Member

junlincc commented Feb 11, 2021

LGTM functionality wise. ✅ We should tweak UI when we implement drag and drop query, will also need special treatment for sort-by single metric.
cc @mihir174 @zhaoyongjie @kgabryje

Screen Shot 2021-02-11 at 3 46 56 PM

https://www.figma.com/file/JWaGztdhZS0kS5ruG7x9tB/Control-Panel?node-id=195%3A36068

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktmud
Copy link
Member

ktmud commented Feb 15, 2021

Merging to unblock #13100

@ktmud ktmud changed the title feat: Single metric sort feat: add sort_by_metric flag for charts with single metric Feb 15, 2021
@ktmud ktmud changed the title feat: add sort_by_metric flag for charts with single metric feat: add sort_by_metric for charts with single metric Feb 15, 2021
@ktmud ktmud merged commit 24ebf10 into apache:master Feb 15, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:sort Related to sorting in Explore size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants