-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sort_by_metric for charts with single metric #13058
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13058 +/- ##
===========================================
+ Coverage 53.06% 66.68% +13.61%
===========================================
Files 489 491 +2
Lines 17314 28944 +11630
Branches 4482 0 -4482
===========================================
+ Hits 9187 19300 +10113
- Misses 8127 9644 +1517
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@maloun96 thanks for the PR and dedicated work, Victor! when I pulled for testing, changes are not showing, did I miss something? |
LGTM functionality wise. ✅ We should tweak UI when we implement drag and drop query, will also need special treatment for sort-by single metric. |
bbbd8bd
to
75666cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging to unblock #13100 |
SUMMARY
Add sort_by_metric flag for charts with single metric
Related: #12674
After
legacy-plugin-chart-heatmap
legacy-plugin-chart-sunburst
legacy-plugin-chart-force-directed
legacy-plugin-chart-chord
legacy-plugin-world-map
ADDITIONAL INFORMATION