-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: speedup celery tests #12885
test: speedup celery tests #12885
Conversation
Hey! Could you look at it? @willbarrett @dpgaspar |
Codecov Report
@@ Coverage Diff @@
## master #12885 +/- ##
==========================================
- Coverage 64.89% 63.38% -1.52%
==========================================
Files 1024 489 -535
Lines 50168 30197 -19971
Branches 5148 0 -5148
==========================================
- Hits 32557 19139 -13418
+ Misses 17433 11058 -6375
+ Partials 178 0 -178
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! the wait loop could be method so you don't repeat yourself
Hey! Could you look at it? @willbarrett @dpgaspar |
SUMMARY
Speedup async celery tests by querying db in 0.5 s intervals instead of waiting 6s.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION