Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore v2] fix explorev2 chart errors #1277

Merged
merged 4 commits into from
Oct 6, 2016
Merged

[explore v2] fix explorev2 chart errors #1277

merged 4 commits into from
Oct 6, 2016

Conversation

ascott
Copy link

@ascott ascott commented Oct 6, 2016

  • only show line chart if viz type is line
  • fix proptype validations

@vera-liu

@vera-liu
Copy link
Contributor

vera-liu commented Oct 6, 2016

thanks for the quick fix! 👍

@@ -26,16 +26,14 @@ export default class TimeSeriesLineChart extends React.Component {
}

renderLines() {
return this.props.data.map((d) => {
return (
return this.props.data.map((d) => (
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure this will work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, TIL arrow functions can just return objects:

return this.props.data.map((d) => (
  <V.VictoryLine
    key={d.key}
    data={d.values}
    interpolation="cardinal"
    style={{ data: { stroke: this.keysToColorsMap[d.key] } }}
   />
));

@vera-liu vera-liu merged commit 8a5f050 into apache:master Oct 6, 2016
@dpgaspar dpgaspar mentioned this pull request Feb 19, 2020
12 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants