Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change userId, dbId to username and dbname #1274

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Change userId, dbId to username and dbname #1274

merged 1 commit into from
Oct 6, 2016

Conversation

vera-liu
Copy link
Contributor

@vera-liu vera-liu commented Oct 6, 2016

Done:

  • Change userId and dbId in query search page to db name and user names
  • use encodeURI for sql to resolve problem with line returns

After:
screen shot 2016-10-06 at 9 23 40 am

needs-review @mistercrunch @bkyryliuk @ascott

@mistercrunch
Copy link
Member

LGTM

@vera-liu vera-liu merged commit 5c5b393 into apache:master Oct 6, 2016
@vera-liu vera-liu deleted the vliu_search_polish_2 branch November 1, 2016 19:02
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@jayakrishnankk @jayakrishnankarolilnlsn @zhaoyongjie
feat(chart-controls): d3 formatting with .2% apache#1274 (apache#1275)
6a71bbe 
Co-authored-by: Jayakrishnan Karolil <[email protected]>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@jayakrishnankk @jayakrishnankarolilnlsn @zhaoyongjie
feat(chart-controls): d3 formatting with .2% apache#1274 (apache#1275)
dedb4d2 
Co-authored-by: Jayakrishnan Karolil <[email protected]>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@jayakrishnankk @jayakrishnankarolilnlsn @zhaoyongjie
feat(chart-controls): d3 formatting with .2% apache#1274 (apache#1275)
93fac5c 
Co-authored-by: Jayakrishnan Karolil <[email protected]>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@jayakrishnankk @jayakrishnankarolilnlsn @zhaoyongjie
feat(chart-controls): d3 formatting with .2% apache#1274 (apache#1275)
15fbe4a 
Co-authored-by: Jayakrishnan Karolil <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vera-liu @mistercrunch