-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore[explore]: Save date if Ok not clicked #12731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customeFrame has 3 Datepicker.
Codecov Report
@@ Coverage Diff @@
## master #12731 +/- ##
===========================================
- Coverage 62.75% 48.40% -14.35%
===========================================
Files 1021 477 -544
Lines 49960 17091 -32869
Branches 4891 4399 -492
===========================================
- Hits 31352 8273 -23079
+ Misses 18408 8818 -9590
+ Partials 200 0 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thanks for the change!
✅
https://user-images.githubusercontent.com/67837651/105698704-16d6c000-5ebb-11eb-8dae-4aa49616a0c4.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Save date if Ok not clicked * answering. comments
SUMMARY
If the user does not click on Ok button in Time Range date picker but clicks outside of the modal instead, the picked date is saved.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Age.distribution.mp4
TEST PLAN
ADDITIONAL INFORMATION
closes [explore]Date picker randomly changes date #12704