Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: test connection raises only command exceptions #12307

Merged
merged 5 commits into from
Jan 8, 2021

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jan 6, 2021

SUMMARY

Small refactor to test connection API and command to allow unsafe connections message surface back to the users and make the command only raise CommandException exceptions

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #12307 (6487c80) into master (e660723) will decrease coverage by 15.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12307       +/-   ##
===========================================
- Coverage   67.13%   51.46%   -15.68%     
===========================================
  Files        1002      466      -536     
  Lines       49289    16805    -32484     
  Branches     5006     4321      -685     
===========================================
- Hits        33091     8648    -24443     
+ Misses      16073     8157     -7916     
+ Partials      125        0      -125     
Flag Coverage Δ
cypress 51.46% <ø> (+0.04%) ⬆️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 11.76% <0.00%> (-88.24%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
superset-frontend/src/components/IconTooltip.tsx 13.33% <0.00%> (-86.67%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...end/src/SqlLab/components/ExploreResultsButton.jsx 8.00% <0.00%> (-84.00%) ⬇️
...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx 14.70% <0.00%> (-82.97%) ⬇️
... and 855 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e660723...6487c80. Read the comment docs.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 7, 2021
@dpgaspar dpgaspar marked this pull request as ready for review January 7, 2021 14:16
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉

@dpgaspar dpgaspar merged commit c685c9e into apache:master Jan 8, 2021
@dpgaspar dpgaspar deleted the fix/db-security-exception branch January 8, 2021 13:10
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants