-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: test connection raises only command exceptions #12307
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12307 +/- ##
===========================================
- Coverage 67.13% 51.46% -15.68%
===========================================
Files 1002 466 -536
Lines 49289 16805 -32484
Branches 5006 4321 -685
===========================================
- Hits 33091 8648 -24443
+ Misses 16073 8157 -7916
+ Partials 125 0 -125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🎉
SUMMARY
Small refactor to test connection API and command to allow unsafe connections message surface back to the users and make the command only raise CommandException exceptions
ADDITIONAL INFORMATION