-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added release notes and associated media for 0.38 #12022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12022 +/- ##
==========================================
+ Coverage 66.91% 67.15% +0.23%
==========================================
Files 994 1002 +8
Lines 49095 49231 +136
Branches 4983 5000 +17
==========================================
+ Hits 32852 33059 +207
+ Misses 16118 16049 -69
+ Partials 125 123 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thank Robert! |
See it rendered here: Comments:
|
Addressed in most recent commits. New location: |
@garden-of-delete Github's MD supports
|
[List of backwards incompatible changes](https://github.com/apache/incubator-superset/blob/master/UPDATING.md#0380) | ||
|
||
## Complete Changelog | ||
For the complete chnagelog please see [apache/incubator-superset/CHANGELOG.md](https://github.com/apache/incubator-superset/blob/master/CHANGELOG.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling nit: changelog
Super nit-picky, but can we add borders to images? https://stackoverflow.com/questions/37349314/is-it-possible-to-add-border-to-image-in-github-markdown Looks a bit rough here: |
Trying the old close/reopen trick since Cypress is not complying |
…he 0.38 release notes.
Swapped out github style markdown embed tags with html style ones for more control.
Fixed a couple small inconsistencies in the feature tags
Seems like GitHub does not any but the most basic css in the embed tag.
Added a box around the images to clearly distinguish them from the whitespace. Images are now embedded on the same indentation tier as their associated bullet point.
Nit: would love to see |
SUMMARY
We would like to publish release notes with each major release. This is a first crack at sorting out the format for the release notes, starting with v0.38. These are the decision points that would benefit from feedback or objections, and will likely see iteration in future release notes:
The changes in this PR make a suggestion for each of those points.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
No testing required, no changes to codebase.
ADDITIONAL INFORMATION