[security] allow for requesting access when denied on a dashboard view #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
request_access_dash
branch
from
86a58b0 to
5aa8412
Compare
bkyryliuk
reviewed
Sep 26, 2016
|
|
||
| duplicates = ( |
There was a problem hiding this comment.
could you please move it into the loop above to avoid creation of the duplicate requests ?
|
Nice approach with implementing the action on the endpoint, should I follow it in my following PRs ? |
|
LGTM, once tests are fixed. Thanks @mistercrunch ! |
mistercrunch
force-pushed
the
request_access_dash
branch
from
5aa8412 to
791360e
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bkyryliuk I had to change the approach a bit to make this work. Also got rid of the
request_accessendpoint by adding support for&action=gotorequest_access_form