Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding SaveDatasetModal component #11861

Merged
merged 104 commits into from
Dec 3, 2020
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Nov 30, 2020

SUMMARY

Adding save modal dataset which will handle the flow of a user either overwriting or saving a new dataset

Component of #11755

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Dec 2, 2020
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Dec 2, 2020
? []
: userDatasetsOwned.map(d => ({
value: d.dataSetName,
dataSetId: d.dataSetId,
Copy link
Member

@betodealmeida betodealmeida Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: datasetId, for consistency

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hughhhh hughhhh merged commit 9ae2f95 into master Dec 3, 2020
@hughhhh hughhhh deleted the so-1117-savedatasetmodal branch December 3, 2020 19:14
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants