feat(db-engine-specs): add support for Postgres root cert #11720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/postgres-ssl
branch
from
a88d49d to
dc58243
Compare
villebro
commented
Nov 17, 2020
| @@ -148,7 +148,6 @@ def test_create_database(self): | |||
| database_data = { | |||
| "database_name": "test-create-database", | |||
| "sqlalchemy_uri": example_db.sqlalchemy_uri_decrypted, | |||
| "server_cert": ssl_certificate, | |||
There was a problem hiding this comment.
Enabling the ssl_certificate fixture raises an error when trying to access the example database on Postgres (as it should), therefore this needs to be removed.
villebro
force-pushed
the
villebro/postgres-ssl
branch
from
dc58243 to
77abb23
Compare
Codecov Report
@@ Coverage Diff @@
## master #11720 +/- ##
==========================================
+ Coverage 65.97% 70.67% +4.70%
==========================================
Files 1015 529 -486
Lines 49548 19779 -29769
Branches 5080 5129 +49
==========================================
- Hits 32687 13978 -18709
+ Misses 16714 5671 -11043
+ Partials 147 130 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/postgres-ssl
branch
from
77abb23 to
d847839
Compare
dpgaspar
approved these changes
Jan 11, 2021
villebro
force-pushed
the
villebro/postgres-ssl
branch
from
0ba5fa6 to
eb7d7ba
Compare
villebro
force-pushed
the
villebro/postgres-ssl
branch
from
eb7d7ba to
69e38c3
Compare
dpgaspar
approved these changes
Jan 13, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 14, 2021
* feat(db-engine-specs): add support for Postgres root cert * remove logging of json decode exception message * fix error message * fix error message
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for SSL root cert verification to Postgres. Also add proper error message for incorrect test request if e.g.
extrais not parseable (see screenshot below).BEFORE
With the following unparseable database extra object, the following toast is raised (does not actually show on some versions of Chrome):
AFTER
The new error toast shows the marshmallow error:
When also specifying an incorrect connection string, the following error is displayed (both errors are displayed):
TEST PLAN
CI + new tests. Also added missing tests to Druid connector.
ADDITIONAL INFORMATION