Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templating): Safer Jinja template processing #11704

Merged
merged 14 commits into from
Nov 17, 2020
Merged

feat(templating): Safer Jinja template processing #11704

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7e45c67
Enable safer Jinja template processing
robdiciuccio Nov 14, 2020
e6ff845
Allow JINJA_CONTEXT_ADDONS with SAFE_JINJA_PROCESSING
robdiciuccio Nov 16, 2020
cb2fd94
Make template processor initialization less magical, refactor classes
robdiciuccio Nov 16, 2020
cce6d2b
Consolidat Jinja logic, remove config flag in favor of sane defaults
robdiciuccio Nov 17, 2020
c11ac0a
Restore previous ENABLE_TEMPLATE_PROCESSING default
robdiciuccio Nov 17, 2020
e37b20e
Add recursive type checking, update tests
robdiciuccio Nov 17, 2020
aa2bb5d
remove erroneous config file
robdiciuccio Nov 17, 2020
44a084e
Remove TableColumn models from template context
robdiciuccio Nov 17, 2020
69ddd6d
pylint refactoring
robdiciuccio Nov 17, 2020
e1ff657
Add entry to UPDATING.md
robdiciuccio Nov 17, 2020
c0e65ce
Merge branch master
robdiciuccio Nov 17, 2020
bc2fc01
Resolve botched merge conflict
robdiciuccio Nov 17, 2020
a9461e4
Update docs on running single python test
robdiciuccio Nov 17, 2020
f7fbd59
Refactor template context checking to support engine-specific methods
robdiciuccio Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add entry to UPDATING.md
  • Loading branch information
@robdiciuccio
robdiciuccio committed Nov 17, 2020
commit e1ff6578568511bd59ff17fbcdfc43cb3051a072
4 changes: 3 additions & 1 deletion UPDATING.md
View file
Original file line number Diff line number Diff line change
@@ -23,6 +23,8 @@ assists people when migrating to a new version.

## Next

* [11704](https://github.com/apache/incubator-superset/pull/11704) Breaking change: Jinja templating for SQL queries has been updated, removing default modules such as `datetime` and `random` and enforcing static template values. To restore or extend functionality, use `JINJA_CONTEXT_ADDONS` and `CUSTOM_TEMPLATE_PROCESSORS` in `superset_config.py`.

* [11575](https://github.com/apache/incubator-superset/pull/11575) The Row Level Security (RLS) config flag has been moved to a feature flag. To migrate, add `ROW_LEVEL_SECURITY: True` to the `FEATURE_FLAGS` dict in `superset_config.py`.

* NOTICE: config flag ENABLE_REACT_CRUD_VIEWS has been set to `True` by default, set to `False` if
@@ -36,7 +38,7 @@ assists people when migrating to a new version.
and requires more work. You can easily turn on the languages you want
to expose in your environment in superset_config.py

* [11172](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
* [11172](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True in `FEATURE_FLAGS`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should prevent DEFAULT_FEATURE_FLAGS from being overridden by custom config files/modules.


* [11155](https://github.com/apache/incubator-superset/pull/11155): The `FAB_UPDATE_PERMS` config parameter is no longer required as the Superset application correctly informs FAB under which context permissions should be updated.