Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cypress): Fix issue with cypress code-coverage plugin when running locally #11698

Merged
merged 6 commits into from
Nov 15, 2020

Conversation

robdiciuccio
Copy link
Member

SUMMARY

This PR:

CypressError: `cy.task('coverageReport')` failed with the following error:
> Cannot read property 'loc' of undefined

Refs:
cypress-io/code-coverage#216
istanbuljs/istanbuljs#572

TEST PLAN

Run Cypress locally

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@robdiciuccio

This comment has been minimized.

@ktmud
Copy link
Member

ktmud commented Nov 13, 2020

I think this just disabled code coverage report for https://codecov.io/

@ktmud
Copy link
Member

ktmud commented Nov 13, 2020

Can you try

  "nyc": {
    "reporter": ["text-summary", "json"]
  }

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #11698 (1457bdf) into master (ec8ccd4) will increase coverage by 4.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11698      +/-   ##
==========================================
+ Coverage   62.86%   66.97%   +4.11%     
==========================================
  Files         889      889              
  Lines       43054    43063       +9     
  Branches     4016     4017       +1     
==========================================
+ Hits        27064    28843    +1779     
+ Misses      15811    14118    -1693     
+ Partials      179      102      -77     
Flag Coverage Δ
cypress 55.97% <ø> (?)
javascript 62.81% <ø> (+<0.01%) ⬆️
python 62.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/components/LimitControl.tsx 89.36% <0.00%> (-1.95%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 74.24% <0.00%> (-1.15%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 77.17% <0.00%> (-0.85%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 73.03% <0.00%> (-0.83%) ⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 58.62% <0.00%> (-0.69%) ⬇️
...tend/src/views/CRUD/annotation/AnnotationModal.tsx 66.14% <0.00%> (-0.53%) ⬇️
.../src/components/dataViewCommon/TableCollection.tsx 100.00% <0.00%> (ø)
...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx 85.45% <0.00%> (+0.26%) ⬆️
superset-frontend/src/views/CRUD/utils.tsx 50.00% <0.00%> (+1.21%) ⬆️
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 60.75% <0.00%> (+1.26%) ⬆️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8ccd4...1457bdf. Read the comment docs.

@mistercrunch
Copy link
Member

Side note, have you all noticed that cypress' reported line numbers are off? Somehow the sourcemap must be wrong for cypress.

@mistercrunch mistercrunch merged commit 700c7c5 into apache:master Nov 15, 2020
@mistercrunch mistercrunch deleted the rd/cypress-local-code-coverage branch November 15, 2020 21:16
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
…ing locally (apache#11698)

* Update @cypress/code-coverage to latest

* Set nyc reporter to html/text

* Revert dashboard list test changes from apache#11613

* Update codecov reporting to summary format

* Add json reporter for codecov.io

* Silence inline coverage reports
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants