chore: remove a few obsolete logic #11676
Conversation
| changed_on_humanized: slice.changed_on_delta_humanized, | ||
| }; | ||
| } | ||
| slices[slice.id] = { |
There was a problem hiding this comment.
we don't have markup or separator viz_type anymore
| @@ -35,8 +35,6 @@ import { NEW_TAB_ID, DASHBOARD_ROOT_ID } from '../../util/constants'; | |||
| import { RENDER_TAB, RENDER_TAB_CONTENT } from './Tab'; | |||
| import { TAB_TYPE } from '../../util/componentTypes'; | |||
|
|
|||
| const MAX_TAB_COUNT = 10; | |||
There was a problem hiding this comment.
we used to limit number of tabs in dashboard, to avoid tabs wrapping. AntD has better solution to manage this. remove limit!
Codecov Report
@@ Coverage Diff @@
## master #11676 +/- ##
==========================================
+ Coverage 62.36% 62.77% +0.41%
==========================================
Files 875 887 +12
Lines 42374 42917 +543
Branches 3989 3988 -1
==========================================
+ Hits 26426 26942 +516
- Misses 15769 15797 +28
+ Partials 179 178 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
could you add the details from the comment into the PR summary that way it's easier to see it when visiting the PR someday? Perhaps into the PR title too if it fits. Thanks! |
I add details in description. It's too long to fit in title... |
mistercrunch
added
🏷️ bot
SUMMARY
Remove a few obsolete logic after recent new features and improvements:
TEST PLAN
CI