-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(examples): missing expressions in birth_names #11141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
approved these changes
Oct 2, 2020
nytai
approved these changes
Oct 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #11141 +/- ##
==========================================
+ Coverage 65.80% 65.86% +0.05%
==========================================
Files 826 826
Lines 39019 39032 +13
Branches 3667 3677 +10
==========================================
+ Hits 25678 25709 +31
+ Misses 13231 13213 -18
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dpgaspar
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 6, 2020
* fix(examples): missing expressions in birth_names * disable flaky tests
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* fix(examples): missing expressions in birth_names * disable flaky tests
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix(examples): missing expressions in birth_names * disable flaky tests
mistercrunch
added
🍒 0.38.0
🍒 0.38.1
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 1.0.0
labels
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The metadata fetch call in
load-examples
erases the addednum_california
andsum__num
expressions. By fetching before adding the expressions they are not erased prior to the commit.BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION