Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): missing expressions in birth_names #11141

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

villebro
Copy link
Member

@villebro villebro commented Oct 2, 2020

SUMMARY

The metadata fetch call in load-examples erases the added num_california and sum__num expressions. By fetching before adding the expressions they are not erased prior to the commit.

BEFORE

image

AFTER

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro requested a review from nytai October 2, 2020 20:11
@codecov-commenter
Copy link

Codecov Report

Merging #11141 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11141      +/-   ##
==========================================
+ Coverage   65.80%   65.86%   +0.05%     
==========================================
  Files         826      826              
  Lines       39019    39032      +13     
  Branches     3667     3677      +10     
==========================================
+ Hits        25678    25709      +31     
+ Misses      13231    13213      -18     
  Partials      110      110              
Flag Coverage Δ
#cypress 56.21% <ø> (-0.13%) ⬇️
#javascript 62.20% <ø> (-0.02%) ⬇️
#python 61.35% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/birth_names.py 100.00% <100.00%> (ø)
.../explore/components/controls/DatasourceControl.jsx 73.07% <0.00%> (-11.54%) ⬇️
.../src/explore/components/AdhocMetricEditPopover.jsx 75.64% <0.00%> (-5.13%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 73.21% <0.00%> (-1.79%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 82.35% <0.00%> (-0.85%) ⬇️
...src/explore/components/controls/MetricsControl.jsx 89.69% <0.00%> (-0.61%) ⬇️
superset/views/core.py 74.30% <0.00%> (+0.24%) ⬆️
...erset-frontend/src/datasource/DatasourceEditor.jsx 71.36% <0.00%> (+0.45%) ⬆️
superset/models/core.py 88.39% <0.00%> (+0.82%) ⬆️
...t-frontend/src/dashboard/actions/dashboardState.js 51.63% <0.00%> (+1.30%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e90c63f...08c5e9f. Read the comment docs.

@villebro villebro merged commit 662fb43 into apache:master Oct 2, 2020
@villebro villebro deleted the villebro/fix-num-california branch October 2, 2020 20:47
dpgaspar pushed a commit to preset-io/superset that referenced this pull request Oct 6, 2020
* fix(examples): missing expressions in birth_names

* disable flaky tests
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* fix(examples): missing expressions in birth_names

* disable flaky tests
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix(examples): missing expressions in birth_names

* disable flaky tests
@mistercrunch mistercrunch added 🍒 0.38.0 🍒 0.38.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🍒 0.38.0 🍒 0.38.1 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants