fix: fix table existence validation function #11066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
force-pushed
the
bogdan/fix_create_dataset
branch
3 times, most recently
from
ddd61a5
to
65cb654
Compare
bkyryliuk
force-pushed
the
bogdan/fix_create_dataset
branch
from
65cb654
to
76f1e1c
Compare
bkyryliuk
changed the title
bkyryliuk
commented
Sep 28, 2020
superset/connectors/sqla/models.py
Outdated
| @@ -453,7 +453,7 @@ class SqlaTable( # pylint: disable=too-many-public-methods,too-many-instance-at | |||
| owner_class = security_manager.user_model | |||
|
|
|||
| __tablename__ = "tables" | |||
| __table_args__ = (UniqueConstraint("database_id", "table_name"),) | |||
| __table_args__ = (UniqueConstraint("database_id", "schema", "table_name"),) | |||
There was a problem hiding this comment.
@john-bodley - do you know if there are any issues with changing table_args here?
There was a problem hiding this comment.
@bkyryliuk this will not work per #5449.
There was a problem hiding this comment.
thanks @john-bodley, reverted this line
nytai
approved these changes
Sep 29, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* Fix table existance validation function * Drop left over table name index in mysql db * Do not modify model Co-authored-by: bogdan kyryliuk <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
TEST PLAN