Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump node version on Dockerfile to be on par with docker-compose #10813

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

fguarini
Copy link
Contributor

@fguarini fguarini commented Sep 8, 2020

SUMMARY

Bump node version used on Dockerfile from '10-jessie' to '12' so it's on par with docker-compose

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #10813 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10813      +/-   ##
==========================================
- Coverage   61.23%   61.12%   -0.11%     
==========================================
  Files         802      802              
  Lines       37815    37815              
  Branches     3557     3557              
==========================================
- Hits        23155    23116      -39     
- Misses      14474    14513      +39     
  Partials      186      186              
Flag Coverage Δ
#javascript 61.62% <ø> (ø)
#python 60.83% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 73.54% <0.00%> (-8.75%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 97.36% <0.00%> (-2.64%) ⬇️
superset/models/core.py 88.05% <0.00%> (-0.28%) ⬇️
superset/connectors/sqla/models.py 89.61% <0.00%> (-0.14%) ⬇️
superset/sql_lab.py 78.69% <0.00%> (+0.43%) ⬆️
superset/result_set.py 98.34% <0.00%> (+1.65%) ⬆️
superset/db_engine_specs/sqlite.py 75.00% <0.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae80d3...51ed871. Read the comment docs.

@craig-rueda craig-rueda merged commit 3b4a992 into apache:master Sep 9, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants