feat: add/edit database modal form sections UI #10745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riahk
force-pushed
the
moriah/db-modal-forms
branch
2 times, most recently
from
8ed4b70 to
3fb83c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #10745 +/- ##
==========================================
- Coverage 65.49% 61.33% -4.17%
==========================================
Files 803 803
Lines 37931 38044 +113
Branches 3561 3605 +44
==========================================
- Hits 24843 23334 -1509
- Misses 12982 14524 +1542
- Partials 106 186 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
The "Test Connection" button on the screenshot looks out-of-theme. On the source side it looks normal though, I'm unclear why. |
nytai
reviewed
Sep 3, 2020
|
@mistercrunch It seems the recent button work yielded this slightly taller CTA button. I'm guessing somewhere in the consolidation we inherited some extra styling on this flavor of button. |
riahk
force-pushed
the
moriah/db-modal-forms
branch
2 times, most recently
from
d58af92 to
6c24371
Compare
|
@riahk looks like this needs a rebase |
riahk
force-pushed
the
moriah/db-modal-forms
branch
from
6c24371 to
fa434ad
Compare
riahk
force-pushed
the
moriah/db-modal-forms
branch
from
a2e97bb to
5183cd5
Compare
nytai
approved these changes
Sep 10, 2020
superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
Outdated
Show resolved
Hide resolved
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
useSingleViewResourcehook for get/post/put functionalityBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
DatabaseModal_spec.jsxADDITIONAL INFORMATION