-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(db_engine_specs): mysql longtext type should not be numeric #10661
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10661 +/- ##
==========================================
- Coverage 64.32% 60.16% -4.17%
==========================================
Files 784 784
Lines 36952 36951 -1
Branches 3529 3529
==========================================
- Hits 23769 22231 -1538
- Misses 13074 14533 +1459
- Partials 109 187 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@villebro Thanks for the fast fix, If possible please give suggestions on the following, For my use case, I have multiple dashboards from different databases but the table name will be the same across databases, In order to make this possible I changed the unique constraint on table_name to unique (database_id,table_name), for now, I don't face any issues because of this, but is there any better way to do this I have to create a user, role, and database programmatically in superset I have implemented this using #3083 (comment) I tried to identify the right rest endpoints but could not I use superset version 0.36.0 from pip in windows 10 |
@abhishekkumaresan I agree, the unique table name constraint is problematic, and would optimally be replaced with ( @dpgaspar is probably the best person to help with programmatic creation of users. |
@abhishekkumaresan, currently there is no "official" / "right" way to create users or roles programatically and remote ( via a REST API ). A database creation API endpoint is just around the corner on the roadmap so stay tuned. |
SUMMARY
Currently the MySQL type
LONGTEXT
is flagged asis_numeric
due to the.*LONG.*
pattern for numeric types. This makes the generic matching rule more specific forLONG
types, and addsBIT
as a default numeric type, as it is commonly a numeric datatype.TEST PLAN
CI + new tests. We should add similar tests to all officially supported databaases to ensure column types are flagged correctly.
ADDITIONAL INFORMATION
FYI: @abhishekkumaresan