feat: card view bulk select #10607
Merged
feat: card view bulk select #10607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think noticed on the video that the border size changes, creating some jitter. One way around this is to have the border size fixed, but going from transparent to a color. |
Codecov Report
@@ Coverage Diff @@
## master #10607 +/- ##
==========================================
- Coverage 64.49% 60.10% -4.39%
==========================================
Files 776 778 +2
Lines 36585 36713 +128
Branches 3464 3463 -1
==========================================
- Hits 23595 22068 -1527
- Misses 12883 14458 +1575
- Partials 107 187 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
reviewed
Aug 18, 2020
| }: CardProps) { | ||
| return ( | ||
| <StyledCard | ||
| cover={ | ||
| <Cover> | ||
| <a href={url}> | ||
| <a href={bulkSelectEnabled ? undefined : url}> |
There was a problem hiding this comment.
can we move this logic up into the renderCard functions? We can make url optional and not pass it down when bulkSelect is enabled, that way this component doesn't need to know about bulk select.
There was a problem hiding this comment.
Alternatively, we may just be able to do a
e.preventDefault();
e.stopPropagation();in the CardWrapper's onClick handler, when bulkSelect is enabled, to prevent events from triggering on the children.
| row.isSelected && bulkSelectEnabled ? 'card-selected' : '' | ||
| } | ||
| key={row.id} | ||
| onClick={() => row.toggleRowSelected()} |
There was a problem hiding this comment.
We should probably check to see if bulkSelectEnabled before firing this. Like this, I think it's possible to select cards even if bulkSelect is not enabled.
amitmiran137
pushed a commit
to amitmiran137/incubator-superset
that referenced
this pull request
Aug 21, 2020
* master: (43 commits) feat: Getting fancier with Storybook (apache#10647) fix: dedup groupby in viz.py while preserving order (apache#10633) feat: bump superset-ui for certified tag (apache#10650) feat: setup react page with submenu for datasources listview (apache#10642) feat: add certification to metrics (apache#10630) feat(viz-plugins): add date formatting to pivot-table (apache#10637) fix: controls scroll issue (apache#10644) feat: Allow tests files in /src (plus Label component tests) (apache#10634) fix: remove duplicated params and cache_timeout from list_columns; add viz_type to list_columns (apache#10643) chore: splitting button stories into separate stories (apache#10631) refactor: remove slice level label_colors from dashboard init load (apache#10603) feat: card view bulk select (apache#10607) style: Label styling/storybook touchups (apache#10627) fix: removing unsupported modal sizes (apache#10625) feat(datasource): remove deleted columns and update column type on metadata refresh (apache#10619) improve documentation for country maps (apache#10621) chore: npm audit fix as of 2020-08-15 (apache#10613) feat: dataset REST API for distinct values (apache#10595) chore: bump react-redux to 5.1.2, whittling console noise (apache#10602) fixing console error about bad html attribute (apache#10604) ... # Conflicts: # superset-frontend/src/explore/components/ExploreViewContainer.jsx # superset-frontend/src/views/App.tsx # superset/config.py
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
updated video
https://www.loom.com/share/70d0f0419e2b4012bde0a4438e8510d3
TEST PLAN
WIP
ADDITIONAL INFORMATION