Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump react-redux to 5.1.2, whittling console noise #10602

Merged
merged 3 commits into from
Aug 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
276 changes: 138 additions & 138 deletions superset-frontend/package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion superset-frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
"react-json-tree": "^0.11.2",
"react-jsonschema-form": "^1.2.0",
"react-markdown": "^4.3.1",
"react-redux": "^5.0.2",
"react-redux": "^5.1.2",
"react-router-dom": "^5.1.2",
"react-search-input": "^0.11.3",
"react-select": "^3.1.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('Dashboard', () => {
expect(wrapper.find(DashboardBuilder)).toExist();
});

describe('componentWillReceiveProps', () => {
describe('UNSAFE_componentWillReceiveProps', () => {
const layoutWithExtraChart = {
...props.layout,
1001: newComponentFactory(CHART_TYPE, { chartId: 1001 }),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ describe('SliceAdder', () => {
props.fetchAllSlices.restore();
});

describe('componentWillReceiveProps', () => {
describe('UNSAFE_componentWillReceiveProps', () => {
let wrapper;
beforeEach(() => {
wrapper = shallow(<SliceAdder {...props} />);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ describe('ExploreViewContainer', () => {
expect(wrapper.find(ChartContainer)).toExist();
});

describe('componentWillReceiveProps()', () => {
describe('UNSAFE_componentWillReceiveProps()', () => {
it('when controls change, should call resetControls', () => {
expect(wrapper.instance().props.controls.viz_type.value).toBe('table');
const resetControls = sinon.stub(
Expand All @@ -91,7 +91,7 @@ describe('ExploreViewContainer', () => {
'triggerQuery',
);

// triggers componentWillReceiveProps
// triggers UNSAFE_componentWillReceiveProps
wrapper.setProps({
controls: {
viz_type: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ describe('SelectControl', () => {
});
});

describe('componentWillReceiveProps', () => {
describe('UNSAFE_componentWillReceiveProps', () => {
it('sets state.options if props.choices has changed', () => {
const updatedOptions = [
{ value: 'three', label: 'three' },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('ResultSet', () => {
const wrapper = shallow(<ResultSet {...mockedProps} />);
expect(wrapper.find(FilterableTable)).toExist();
});
describe('componentWillReceiveProps', () => {
describe('UNSAFE_componentWillReceiveProps', () => {
const wrapper = shallow(<ResultSet {...mockedProps} />);
let spy;
beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,14 @@ describe('TabbedSqlEditors', () => {
);
});
});
describe('componentWillReceiveProps', () => {
describe('UNSAFE_componentWillReceiveProps', () => {
let spy;
beforeEach(() => {
wrapper = getWrapper();
spy = sinon.spy(TabbedSqlEditors.prototype, 'componentWillReceiveProps');
spy = sinon.spy(
TabbedSqlEditors.prototype,
'UNSAFE_componentWillReceiveProps',
);
wrapper.setProps({ queryEditors, queries, tabHistory, tables });
});
afterEach(() => {
Expand Down