refactor: reduce test data size #10487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
changed the title
bkyryliuk
force-pushed
the
bogdan/sample_data_for_Tests
branch
8 times, most recently
from
e43664a
to
8fe0200
Compare
Codecov Report
@@ Coverage Diff @@
## master #10487 +/- ##
===========================================
- Coverage 70.84% 59.94% -10.91%
===========================================
Files 605 409 -196
Lines 32428 13355 -19073
Branches 3423 3423
===========================================
- Hits 22975 8006 -14969
+ Misses 9341 5161 -4180
- Partials 112 188 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bkyryliuk
force-pushed
the
bogdan/sample_data_for_Tests
branch
from
8fe0200
to
80372f9
Compare
bkyryliuk
force-pushed
the
bogdan/sample_data_for_Tests
branch
from
80372f9
to
4fa4c5c
Compare
bkyryliuk
force-pushed
the
bogdan/sample_data_for_Tests
branch
from
4fa4c5c
to
9b15c4e
Compare
bkyryliuk
commented
Aug 1, 2020
| @@ -264,13 +264,30 @@ def cannonicalize_df(df): | |||
| return ret | |||
|
|
|||
| df1 = self.query_with_expr_helper(is_timeseries=True, inner_join=True) | |||
| name_list1 = cannonicalize_df(df1).name.values.tolist() | |||
There was a problem hiding this comment.
made the test deterministic
bkyryliuk
changed the title
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
Co-authored-by: bogdan kyryliuk <[email protected]>
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Co-authored-by: bogdan kyryliuk <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some test setup cleanup. This PR is needed to be able to add presto to the CI bkyryliuk#13, presto inserts are fairly slow and takes forever to finish.
The ultimate state is to move off the load examples & leverage the fixtures instead. This step is more intermediate and just reduces the data size loaded into the test databases.