Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up istanbul with codeclimate and travis. #1046

Merged
merged 2 commits into from
Aug 31, 2016
Merged

Set up istanbul with codeclimate and travis. #1046

merged 2 commits into from
Aug 31, 2016

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Aug 31, 2016

Set of changes:

  • Code climate repo token is moved to the repository settings. This allows forks to have test coverage too. More here: https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings
  • upgraded npm on the travis to be 3.9.5 and installed manually node v 5.11 on the travis to allow test to pass. Error message was ``jsdom 7.x onward only works on Node.js 4 or newer: https://github.com/t`. More logs are here: https://travis-ci.org/bkyryliuk/caravel/jobs/156381431
  • Configured istanbul to run on the javascripts folder. There are couple limitations:
  • * include-all-sources flag enforces the tool to process recursively all js and jsx files in the root directory (./javascripts). Because of it we should avoid placing libraries and generated code into that directory as it will drastically slow down the code analysis or will lead node to run out of the memory.
  • Fixed the npm test command the test helper file.
  • Added babel-cli to run the istanbul command.
  • Added codeclimate-test-reporter package to report the stats to the codeclimate.
  • Fixed couple linting errors that were failing the build.

Open issues:

  • codeclimate picks up the coverage data for the default branch and I couldn't make it working for the PRs yet. Waiting for the support to get back to me.
  • codeclimate report script isn't picking up the travis env variable. The hack around it is to include the token in the command.

@mistercrunch
Copy link
Member

Awesome, thanks for digging deep into this!

@mistercrunch
Copy link
Member

LGTM

@bkyryliuk bkyryliuk mentioned this pull request Aug 31, 2016
@bkyryliuk
Copy link
Member Author

Thanks @mistercrunch for the review.
There are 2 issues that have to be resolved, I'll tackled them separately: #1022

@ascott
Copy link

ascott commented Sep 6, 2016

🎉

@dpgaspar dpgaspar mentioned this pull request Jul 8, 2019
3 tasks
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* fix(plugin-chart-echarts): add series deduplication

* refactor function
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* fix(plugin-chart-echarts): add series deduplication

* refactor function
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* fix(plugin-chart-echarts): add series deduplication

* refactor function
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* fix(plugin-chart-echarts): add series deduplication

* refactor function
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants