Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): disable CSRF for chart data endpoint #10397

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 22, 2020

SUMMARY

CSRF exempts by default the chart data REST API endpoint. This is a POST endpoint that is used like a GET endpoint. We use POST because the amount of options is so big we need a payload.

Also did a small refactor on the way CSRF is initialised, now we can import it and use it's decorator if needed

Related to issue #10354, will help user's leverage the chart data API

ADDITIONAL INFORMATION

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Got slightly confused by the description of chart data being a GET endpoint. Perhaps rephrase to indicate that it is a POST endpoint that is used like a GET endpoint due to the large payload requirement.

@dpgaspar
Copy link
Member Author

Yes, reread it and it is confusing :) thks

@dpgaspar dpgaspar merged commit e026406 into apache:master Jul 23, 2020
@dpgaspar dpgaspar deleted the fix/csrf-exempt-chart-data branch July 23, 2020 09:44
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants