Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update dataset editor modal #10347

Merged
merged 13 commits into from
Jul 28, 2020
Merged

feat: update dataset editor modal #10347

merged 13 commits into from
Jul 28, 2020

Conversation

lilykuang
Copy link
Member

SUMMARY

  • reuse dataset editing modal from explore
  • convert ChangeDatasourceModal and DatasourceModal to use hooks
  • test has failed after convert to hooks but I will update test after this pr merge

Future improvement:

  • convert DatasourceEditor to use hooks

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang marked this pull request as draft July 16, 2020 18:52
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #10347 into master will decrease coverage by 0.41%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10347      +/-   ##
==========================================
- Coverage   70.25%   69.83%   -0.42%     
==========================================
  Files         605      196     -409     
  Lines       32377    19070   -13307     
  Branches     3271        0    -3271     
==========================================
- Hits        22745    13317    -9428     
+ Misses       9522     5753    -3769     
+ Partials      110        0     -110
Flag Coverage Δ
#cypress ?
#javascript ?
#python 69.83% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/api.py 92.14% <ø> (ø)
superset/connectors/druid/models.py 82.48% <66.66%> (-0.06%) ⬇️
superset/connectors/sqla/models.py 89.54% <100.00%> (+0.09%) ⬆️
.../dashboard/util/charts/getEffectiveExtraFilters.ts
...shboard/util/charts/getFormDataWithExtraFilters.ts
...nd/src/dashboard/util/getComponentWidthFromDrop.js
superset-frontend/src/components/CachedLabel.jsx
...rontend/src/views/CRUD/dashboard/DashboardList.tsx
superset-frontend/src/components/SearchInput.tsx
...ponents/filterscope/renderFilterScopeTreeNodes.jsx
... and 398 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f56cd5...7aa3e25. Read the comment docs.

@lilykuang lilykuang marked this pull request as ready for review July 21, 2020 16:21
@lilykuang lilykuang closed this Jul 27, 2020
@lilykuang lilykuang reopened this Jul 27, 2020
nytai
nytai reviewed Jul 27, 2020
View reviewed changes
superset-frontend/src/datasource/DatasourceEditor.jsx Outdated
isDruid: props.datasource.type === 'druid',
isSqla: props.datasource.type === 'table',
isDruid:
props.datasource.type === 'druid' || props.datasource.type === 'druid',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a redundant check

nytai
nytai approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just 1 comment

@lilykuang lilykuang closed this Jul 28, 2020
@lilykuang lilykuang reopened this Jul 28, 2020
@nytai
Copy link
Member

nytai commented Jul 28, 2020

@lilykuang Looks like cypress is failing on this test: https://github.com/preset-io/incubator-superset/blob/3445710267cef7cbbee28b2a49785723fc6d3247/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts#L34

It looks like something that could have been broken with this change

mistercrunch
mistercrunch reviewed Jul 28, 2020
View reviewed changes
superset-frontend/src/datasource/ChangeDatasourceModal.tsx
@@ -0,0 +1,161 @@
/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge deal, but let's use git mv to keep the history of the file attached to it! You can fix it quickly with

mv superset-frontend/src/datasource/ChangeDatasourceModal.tsx /tmp
git checkout HEAD^ superset-frontend/src/datasource/ChangeDatasourceModal.tsx
git mv superset-frontend/src/datasource/ChangeDatasourceModal.jsx superset-frontend/src/datasource/ChangeDatasourceModal.tsx
mv /tmp/ChangeDatasourceModal.tsx superset-frontend/src/datasource/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get moving history working for git

@lilykuang lilykuang closed this Jul 28, 2020
@lilykuang lilykuang reopened this Jul 28, 2020
@lilykuang lilykuang closed this Jul 28, 2020
@lilykuang lilykuang reopened this Jul 28, 2020
@lilykuang lilykuang closed this Jul 28, 2020
@lilykuang lilykuang reopened this Jul 28, 2020
@lilykuang
Copy link
Member Author

@lilykuang Looks like cypress is failing on this test: https://github.com/preset-io/incubator-superset/blob/3445710267cef7cbbee28b2a49785723fc6d3247/superset-frontend/cypress-base/cypress/integration/explore/control.test.ts#L34

It looks like something that could have been broken with this change
@nytai The superset/explore page was broken after I updated put endpoint to use api/v1/. It have to be changed back to old endpoint for both dataset list and explore to work.

@lilykuang lilykuang closed this Jul 28, 2020
@lilykuang lilykuang reopened this Jul 28, 2020
@lilykuang lilykuang requested a review from nytai July 28, 2020 06:06
@lilykuang lilykuang closed this Jul 28, 2020
@lilykuang lilykuang reopened this Jul 28, 2020
@nytai nytai merged commit 39fad85 into apache:master Jul 28, 2020
@nytai nytai deleted the lily/dataset-editor branch July 28, 2020 22:54
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@auxten
feat: update dataset editor modal (apache#10347)
4119ae4
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch left review comments

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilykuang @codecov-commenter @nytai @mistercrunch