fix: Fixed bug for issue #9967

[Nj-kol]

SUMMARY

The issue was first observed in #7270
However, in the subsequent releases, the variable time_grain_functions was renamed to _time_grain_expressions. The implementation was also left out for hive. So time functions were not renamed which were specific to Hive. This was causing the group by functions in the Charts to malfunction

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue: closes invalid function date_trunc when connecting to hive -- related to issue #7270 #9967
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[Nj-kol]

@villebro Created this new PR. Could you please review this? Also not sure why the CI is still failing, I installed the git-hook : https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#git-hooks

[villebro]

Can you try to undo the change to setup.cfg and do a commit like this git commit -m "lint" --no-verify and then push that.

[codecov-commenter]

Codecov Report

Merging #10269 into master will decrease coverage by 10.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #10269       +/-   ##
===========================================
- Coverage   70.26%   59.31%   -10.95%     
===========================================
  Files         598      404      -194     
  Lines       32011    13148    -18863     
  Branches     3239     3239               
===========================================
- Hits        22491     7799    -14692     
+ Misses       9417     5168     -4249     
- Partials      103      181       +78     

Flag	Coverage Δ
#cypress	?
#javascript	59.31% <ø> (ø)
#python	?

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/SqlLab/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupFormatters.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
... and 330 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6224edd...f11c30c. Read the comment docs.

[Nj-kol]

Can you try to undo the change to setup.cfg and do a commit like this git commit -m "lint" --no-verify and then push that.

Worked like a charm! Thanks. I hope this should do the trick, request you to review once

[villebro]

Great, thanks for your perseverence @Nj-kol ! 👍

[Nj-kol]

Great, thanks for your perseverence @Nj-kol ! 👍

@villebro A big thanks to you and the community for your patience :)

Hope to contribute a lot more in the coming days!

One question - How do I add my company name to the list of superset users?

[villebro]

Oh, that's easy, just open a single line PR on README.md 🙂

[nielsenrechia]

Hello Guys, thanks for the solution. Just to confirm, it will be included on the version 0.37, right?

Thanks

[villebro]

@nielsenrechia Yeah, gonna be in 0.37.0 👍