Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: reduce forms usage of choicify #583

Closed
xrmx opened this issue Jun 8, 2016 · 1 comment · Fixed by #591
Closed

i18n: reduce forms usage of choicify #583

xrmx opened this issue Jun 8, 2016 · 1 comment · Fixed by #591
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@xrmx
Copy link
Contributor

xrmx commented Jun 8, 2016

Since choicify is not translation friendly forms that have fixed choices should use an explicit choices iterable with labels appropriately marked for translation.
@mistercrunch
Copy link
Member

agreed

@mistercrunch mistercrunch added the enhancement:request Enhancement request submitted by anyone from the community label Jun 9, 2016
xrmx added a commit to xrmx/superset that referenced this issue Jun 9, 2016
@xrmx
caravel: reduce usage of choicify in forms
af726ba 
So that more string can be translated

Fix apache#583
@xrmx xrmx mentioned this issue Jun 9, 2016
Merged
mistercrunch pushed a commit that referenced this issue Jun 9, 2016
@xrmx @mistercrunch
caravel: reduce usage of choicify in forms (#591)
e3da785 
So that more string can be translated

Fix #583
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@villebro @zhaoyongjie
feat(query): add new fields to QueryContext and QueryObject (apache#583)
086c9d0 
* feat: add new fields to QueryContext and QueryObject

* linting

* remove change to package.json
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@villebro @zhaoyongjie
feat(query): add new fields to QueryContext and QueryObject (apache#583)
96aeaeb 
* feat: add new fields to QueryContext and QueryObject

* linting

* remove change to package.json
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@villebro @zhaoyongjie
feat(query): add new fields to QueryContext and QueryObject (apache#583)
cbaa5d8 
* feat: add new fields to QueryContext and QueryObject

* linting

* remove change to package.json
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@villebro @zhaoyongjie
feat(query): add new fields to QueryContext and QueryObject (apache#583)
9955156 
* feat: add new fields to QueryContext and QueryObject

* linting

* remove change to package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

caravel: reduce usage of choicify in forms xrmx/superset
2 participants
@xrmx @mistercrunch