-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve histogram viz #4512
Comments
First pull request: #4513 |
if you're considering updating the vis a lot, you might consider |
Looks great! I'll look into it |
* fixing histogram axes and colors, adding normalized and x-axis label options * adding y-axis label option
* fixing histogram axes and colors, adding normalized and x-axis label options * adding y-axis label option
* fixing histogram axes and colors, adding normalized and x-axis label options * adding y-axis label option
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
@ArielStv I am struggling to find current documentation to implement this graph. Was it deprecated? Or is there some custom work that needs to be done to use this kind of visualisation? |
This issue aims to encapsulate issues #3674, #988 (and in a larger sense #989 and PR #3777).
As it is, the histogram feature doesn't look good with large numbers of bins: the x-ticks, y-ticks, colors and annotations make it unintelligible, and even with a small number of bins, it's not great (in my opinion). It seems to have been an ongoing concern when looking at previous open issues.
I'd like to change that, and take advantage of the opportunity to improve the histogram further.
The thing is, I'm not sure how much the histogram viz is used at the moment. I couldn't find any examples from Superset (or anywhere else) so I'm assuming not much? I'd be interested to know how people are actually using it, since I couldn't find a good use case for it.
If that's the case, we can most likely go on and make changes and improvements on the current histogram feature without worrying too much about breaking stuff for users.
Otherwise, maybe it'd be better to create a new visualization?
I assumed the former for a first pass. I'm going to make 2 pull requests (that I will link below):
The text was updated successfully, but these errors were encountered: