-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query component: limit_spec is not valid for query type: groupBy.The list of valid #4
Comments
Did you install the trunk version of
|
here's the related commit I wrote to add the feature (merged into master, but not on pypi): |
works for me now, thank you |
the-dcruz
added a commit
to the-dcruz/caravel
that referenced
this issue
Oct 25, 2016
…stacked to dev * commit 'fb8eafb73f4099b5eccd8e642f9a34e6eb1cadbc': Fix annotatinos for stacked bar chart
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this issue
Aug 22, 2017
Ch react page
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this issue
Feb 5, 2018
[Sql Lab] Fix query results display at the bottom of screen (apache#4246)
williaster
added a commit
that referenced
this issue
Mar 3, 2018
[builder][tabs] fix broken add tab button
ShirmineWang
pushed a commit
to ShirmineWang/incubator-superset
that referenced
this issue
Jul 2, 2018
flask-debugtoolbar is very very helpful for debugging and developing flask applications. Ref: - https://github.com/mgood/flask-debugtoolbar
dandanhub
pushed a commit
to dandanhub/incubator-superset
that referenced
this issue
Mar 25, 2020
* Visualize after running Ctas query. Stub for table viz Work on the viz Add JS functionality for Ctas viz Add test for the table viz flow Fix test Add js test for the ctas viz * Fix tests
villebro
pushed a commit
that referenced
this issue
Apr 10, 2020
* Visualize after running Ctas query (#4) * Visualize after running Ctas query. Stub for table viz Work on the viz Add JS functionality for Ctas viz Add test for the table viz flow Fix test Add js test for the ctas viz * Fix tests * Resolve comments * Leverate tmpSchema in the query object * Fix i18n string Co-authored-by: bogdan kyryliuk <[email protected]>
craig-rueda
added a commit
that referenced
this issue
Apr 22, 2020
* improve helm chart * add Apache license headers * fix: suburst chart when secondary metric is defined (#9343) * refactor: remove settooltip (#9332) * [config] Fixing GET_FEATURE_FLAGS_FUNC example (#9339) * [config] Fixing GET_FEATURE_FLAGS_FUNC example * Adding typing for GET_FEATURE_FLAGS_FUNC * Update config.py * feat: [SQLLAB] add checkbox to control autocomplete (#9338) * [SQLLAB] add checkbox to control autocomplete * autocomplete -> autocompleteEnabled * fix defaultProps * fix spec * Cal heatmap controls migration (#9355) * controls migrated * linting * migrating unique EventFlow controls (#9358) * migrating unique controls * Lint ✨ * Treemap controls migration (#9352) * Treemap * linting * feat: [explore] don't save filters inherited from a dashboard (#9340) * feat: [explore] don't save filters inherited from a dashboard When navigating to explore from a dashboard context, the current dashboard filter(s) are passed along to explore so that the context is kept. So say you're filtering on "country=Romania", in your dashboard and pivot to explore, that filter is still there and keep on exploring. Now a common issue is that you'll want to make some tweak to your chart that are unrelated to the filter, say toggling the legend off for instance, and then save it. Now you back to your dashboard and even though you started with an "all countries" dashboard, with a global filter on country, now that one chart is stuck on "Romania". Typically you notice this when filtering on something else, say "Italy" and then that one chart now has two mutually exclusive filters, and show "No data". Now, the fix is to flag the filter as "extra" (that's the not-so-good internal name we use for these inherited filters) and make it clear that that specific filter is special and won't be saved when saving the chart. * fix build * [charts] Refactor API using SIP-35 (#9329) * [charts] Refactor charts API using SIP-35 * [charts] Fix, copy pasta * [charts] simplify * Add global install of webpack and webpack-cli to docker-compose (#9310) * [dataset] columns and metrics API (nested) (#9268) * [dataset] columns and metrics API (nested) * [dataset] tests and validation * [datasets] Fix, revert list field name to database_name * Adding requirements-local.txt support (#9357) * Adding requirements-local.txt support * Reverting package-lock.json * Migrate unique Heatmap controls (#9360) * Migrate Heatmap controls * Lint * fix: don't parseFloat when the *already numeric* value ends in a decimal point (#9351) * [sip-15] Fixing typo in docstring (#9377) * [explore view] fix long query issue from Run in SQL LAB Button (#9345) * [explore view] fix long query issue from Run in SQL LAB Button * SQL Lab page needs to take the post form data, too * fix variable names * updated payload dict, rename hidden form Co-authored-by: Jesse Yang <[email protected]> * fix a typo in set prop value (#9383) * Migrating unique DirectedForce controls (#9359) * migrating controls * Linting ✨ * oops... meant to pull this out in a conflict resolution. * Update MANIFEST.in (#9261) Include superset-frontent/package.json in package because setup.py requires it * fix: [dashboard] add row padding (#9381) * Removing WordCloud controls from CONTRIBUTING.md (#9391) * [dashboard] handle markdown error (#9350) * [dashboard] handle markdown error * localize error message, fix review comments. * [cache] Cleaning up viz/cache logic (#9375) Co-authored-by: John Bodley <[email protected]> * migrating controls 🎛 (#9386) * Migrating unique Table controls (#9388) * Migrating unique BoxPlot controls (#9392) * upgrade to react-bootstrap v0.33.1 (#9372) * upgrade to react-bootstrap v0.33.1 * fix test * simplify proptypes Co-Authored-By: Evan Rusackas <[email protected]> * simplify more proptypes Co-Authored-By: Evan Rusackas <[email protected]> Co-authored-by: Evan Rusackas <[email protected]> * migrating unique controls (#9374) * Migrating horizon controls (#9368) * migrating unique controls * linting ✨ * build: use manifest hooks for dev server proxy and fix hot reload for charts (#9333) * Use manifest hooks for dev server proxy * Rewrite dashboard/App.jsx to supress Redux error in hot reload * Update ChartRenderer to allow hot realod in Explore * Fix hot reload in dashboars as well * Revert changes to ChartRenderer.jsx Will submit in another PR. * Clean up * migrating controls (#9373) * [dataset] New, export API endpoint (#9367) * [dataset] New, export API endpoint * Fix, lint * [charts] New, bulk delete API endpoint (#9387) * [charts] New, bulk delete API endpoint * [charts] Fix, typos * [charts] Fix wrong model name * [sip-15] fix messaging (#9397) * Mirgrating unique Partition chart controls (#9385) * mirgrating controls * specific import * feat: add SSL certificate validation for Druid (#9396) * feat: add SSL certificate feature * Address comments * don't mutate extras * Address comments and add polish * Add further polish * [fix] Fixing cache key inconsistencies (#9382) Co-authored-by: John Bodley <[email protected]> * add initjob conf + secret * [dependency] Fix, Bump FAB to 2.3.1 (#9413) * [mypy] Enforcing typing for charts (#9411) Co-authored-by: John Bodley <[email protected]> * add missing headers * [dashboards] Fix, API update slug uniqueness refusing empty string (#9417) * [dashboards] Fix, API update slug uniqueness refusing empty string * [dashboards] tests * Build: fix hot reload for charts (#9400) * Fix hot reload for charts * Override tsc options for plugins Plugins will sometimes have their own `tsconfig.json`, which will interfere with the dev server config if configured inappropriately. This change makes sure `tsc` (and `ts-loader`) always compiles to `esnext` modules, so we don't get "Uncaught ReferenceError: exports is not defined" error. * [fix] allow force refresh for No Results chart (#9408) * [fix] dashboard filter indicator no showing single number value (#9401) * fix pagination for list views (#9425) * feat(visualization): add timeRangeFixed to Big Number w/ Trendlines (#9341) * feat: add timeRangeFixed and increase font size for Big Number chart * Update package-lock.json * [fix]some translation not work better (#9428) * Add check for SSL certificate and add form validators (#9436) * Add check for server_cert falsy and add form validators * Address comments * migrating unique controls (#9446) * Enforcing linting of LESS (#9356) * linting some LESS * enforce linting * moving font binaries out of stylesheets to fonts folder. * renaming font specimen sheet directory. * Migrating unique bigNumber(total) controls (#9440) * migrating options controls * lint ✨ * baby steps... * shared BigNumber controls file * capitalization matters * Migrating unique NVD3 viz controls (#9445) * donut control * labels outside * linting * x_log_scale, pie_label_type * linting * line_charts, line_charts_2 * marker_labels * marker_line_labels, marker_lines, markers * prefix_metric_with_slice_name, range_labels, ranges * stacked_style * Revert "stacked_style" This reverts commit aae2d418b8f1950fbe32248b62e50a12fbf186bd. * stacked_style take 2... * Revert "stacked_style take 2..." This reverts commit 38b7155f50143684c92a67b2a9fa16f65c269d35. * Migrating NVD3 Area's stacked_style config (#9454) * Migrating NVD3 Area's stacked_style config * test mods * lint * nonsense change * undoing nonsense. Come on GitHub, WORK. * Eslint prefer-object-spread (#9466) * The rule. * The result * [mypy] Enforcing typing for some modules (#9416) Co-authored-by: John Bodley <[email protected]> * chore: bump black to 19.10b0 and mypy to 0.770 (#9378) * Bump black to 19.10b0 * Upgrade mypy to 0.770 * Update how inline type is defined * release: Add support for ZSH in RELEASING and add tagging instructions (#9451) * Add support for ZSH in RELEASING and add tagging instructions * fail if unsupported shell * Added dremio (#9472) * [query] New, readonly API (#9403) * [query] New, readonly API * Update tests/queries/api_tests.py Co-Authored-By: Ville Brofeldt <[email protected]> * [mypy] Enforcing typing for superset.examples (#9469) Co-authored-by: John Bodley <[email protected]> * Migrating shared DeckGL controls (#9455) * Missed a couple unique controls! * new shared module, with filter_nulls export. * autozoom * dimension * nixing unneeded import * stroke_width * js_columns * remaining js_* controls * cleaning up unused stuff * legend_format * exports for prior commit * legend_position * line_column * fill_color_picker * filled, stroked, stroke_color_picker * grid_size, extruded * ... more gridsize * viewport * point_radius_fixed, spatial * multiplier, line_type, line_width * reverse_long_lat * lint ✨ * [Doc] Update installation doc for Dremio (#9464) * update installation doc for Dremio Customers fail to install pyodbc properly which on linux systems requires you to install unixodbc-devel package. Update the instructions to make it clear. * fix new line * [mypy] Enforcing typing for superset.dashboards (#9418) * [mypy] Enforcing typing for superset.dashboards * Make return types equal on all commands * Make return types equal on all commands * [dashboard] address comments same return type on commands * lint * lint * [datasets] Add strict type annotation (#9437) * [datasets] Add strict type annotation * Fix refresh endpoint * Improve logic on update * Filter owners select by text input (#9337) * filter owners select by text input * use rison * fix backend owners filter logic * use fullname, not username on owners inputs * fix some tests * fixing tests * deterministic tests * appease linter * add back search by username * more comprehensive filter test * add clarifying text * formatting... * Handle empty dataframes in TableViz (#9480) TableViz fails to display empty dataframes returning an error like: "None of [Index(['project', 'count'], dtype='object')] are in the [columns]" The behavior has been observed while testing 0.36.0rc3 with Druid datasources. issue: #9468 * [sqllab] Add CUSTOM_TEMPLATE_PROCESSOR config (#9376) Co-authored-by: Dandan Shi <[email protected]> * [tests] refactor, change datasets and charts to it's own folder (#9487) * pylint: accept specific 2 character names by default (#9460) * lint: accept 2 letter names by default * Address review comments * Remove e and d from good-names * Upgrade table chart plugin to 0.12.13 (#9493) * feat: change default time range in sql lab explore (#9486) Change from "100 years go" to "no filter". 100 years ago is basically equivalent to no filter, but has implications on how x-axis is plotted on certain charts (e.g. Big Number). * fix: add explore control tabOverride at the section level (#9495) * [query] Migrate api v1 query to new location (#9479) * [query] Migrate api v1 query to new location * Improved errors and tests * [query] nit and revert undesired change * [query] lint * [query] revert nan change * Update superset/queries/api.py Co-Authored-By: Ville Brofeldt <[email protected]> * Update tests/queries/api_tests.py Co-Authored-By: Ville Brofeldt <[email protected]> * change endpoint location to charts Co-authored-by: Ville Brofeldt <[email protected]> * Bump FAB to 2.3.2 (#9491) * [dashboards] Fix, update dashboard owners not propagating to charts o… (#9484) * [dashboards] Fix, update dashboard owners not propagating to charts owners * Add tests * Fix tests * better naming * [dashboards] New, tittle and slug OR filter (#9435) * [dashboards] New, tittle and slug OR filter * Update requirements, because of prison bump * Tests * Fix tests * Avoid like filter on empty string value * merge master brings strict typing to the table * fix: add lineWidth to Shared_DeckGL.jsx (#9496) * fix: add lineWidth to Shared_DeckGL.jsx * linting * apply changes * opps again .... license * feat: Add post processing to QueryObject (#9427) * Add post processing to QueryObject * Simplify sort signature and require explicit sort order * Add new operations and unit tests * linting * Address comments * Simplify test method names * Address comments * Linting * remove unnecessary logic * Apply strict whitelisting to all getattr calls * Add checking of rolling_type_options and add/improve docs * Add visualization flow to the CTA queries (#9370) * Visualize after running Ctas query (#4) * Visualize after running Ctas query. Stub for table viz Work on the viz Add JS functionality for Ctas viz Add test for the table viz flow Fix test Add js test for the ctas viz * Fix tests * Resolve comments * Leverate tmpSchema in the query object * Fix i18n string Co-authored-by: bogdan kyryliuk <[email protected]> * Bump sqlalchemy and dremio deps (#9503) * [charts] New, custom filter for name OR description (#9492) * [charts] New, custom filter for name OR description * Improve test * docker node_modules in its own volume (#9509) * [Dashboard] new listview filters & emotion infra (#9462) * [Dashboard] listview filters to match new design * use title_or_slug filter * use ?. operator * move components to components folder * chore: auto label issues based on the template chosen (#9507) * chore: auto label issues based on the template chosen * quoted stuffs * control to turn off table bar-chart backgrounds (#9500) * control to turn off table bar-chart backgrounds * flipping enable to disable, to support existing charts * lint ✨ * Turn ON to enable (reversing logic) * bumping big number chart * ling ✨ * Another attempt to fix a viz.py bug (#9522) * Another attempt to fix a viz.py bug * Add types to new ddtm attributes * deprecate groupby controls in query_obj (#9366) * Deprecate groupby from query_obj * Fix query_object bug * Fix histogram * Remove groupby from legacy druid connector and fix first batch of unit tests * Deprecate some unnecessary tests + fix a few others * Address comments * hide SIP-38 changes behind feature flag * Break out further SIP-38 related tests * Reslove test errors * Add feature flag to QueryContext * Resolve tests and bad rebase * Backport recent changes from viz.py and fix broken DeckGL charts * Fix bad rebase * backport #9522 and address comments * [dashboard] Fix, improve test for custom filter (#9521) * [api] refactor, remove unnecessary code, using command pattern now (#9520) * Importing validators module from superset-ui (#9465) * importing... this is going to break CI, but there it is. * adding validator package. * pluralization - maybe it should be plural, but whatevs * updating validators to match new exports * removing old validators * lintage ✨ * validateNumeric -> validateNumber * using legacyValidateInteger, legacyValidateNumber * linting ✨ * removing extraneous package lock file * Fix typo in viz.py (#9533) * [Build] Add Github workflows (#9517) As an replacement to Travis CI. * Disabling recording in Cypress tests (#9535) * Disabling recording in Cypress tests * Removing --group --ci-build-id * Run CI on all pushes / PR's (#9538) * [list views] add work-break css for table layouts (#9537) * [thumbnails] API and celery task for dashboards and charts (#8947) * [copy] fix: Row Level Security get_rls_filters func SELECT statement (#9541) * fix: Row Level Security get_rls_filters func SELECT statement * More general RowLevelSecurityTests case to avoid improper ids matching * Make email parsing more robust (#9523) * Make email parsing more robust * Address comment Co-authored-by: bogdan kyryliuk <[email protected]> * docs: point our README the maintained Docker image (#9536) Our README now points to a not-so-well-maintain, community-contributed Docker image. The docker image we link to here is managed and supported by actual committers under the Preset org. * Bump copyright notice (#9539) * Ditching travis config in favor of Github Actions (#9548) * Bump @superset-ui/legacy-plugin-chart-table to 0.12.14 (#9549) * [dashboard] New, add statsd metrics to the API (#9519) * [fix] warm up cache error handling (#9560) Co-authored-by: John Bodley <[email protected]> * [fix] dashboard filter scope bug (#9550) * [Build] Collect frontend code coverage from Cypress tests (#9555) * build: collect code coverage from Cypress Collect frontend code coverage reports from Cypress tests and add proper tagging for all tests. * Fix bash script lint error from shellcheck * Revert Cypress to 4.3.0 to see if it fixes a failing test * chore: Migrate unique FilterBox controls from controls.jsx (#9566) * Migrate FilterBox controls from controls.jsx * Linting * chore: Add OpenAPI docs to /api/v1/chart/data EP (#9556) * Add OpenAPI docs to /api/v1/chart/data EP * Add missing fields to QueryObject, fix linting and unit test errors * Fix unit test errors * abc * Fix errors uncovered by schema validation and add unit test for invalid payload * Add schema for response * Remove unnecessary pylint disable * [pypi] Include compiled translations on Pypi pkg (#9567) * doc: Add changelog for 0.36.0 (#9570) * Migrating shared NVD3 controls to new module (#9525) * proto module * caught a missed 'freq' unique control * line_interpolation * linting * showLegend * show_controls * xAxisLabel * bottomMargin * x_ticks_layout * missed one * x_axis_format * yLogScale * y_axis_bounds * linting * nixing yarn lock * x_axis_showminmax * xAxisShowminmax control * richTooltip * linting, syntax fix * show_bar_value, bar_stacked * reduceXticks, yaxislabel * left_margin, max_bubble_size, y_axis_showminmax * show_labels * send_time_range, y_axis_2_format, show_markers, order_bars * nixing commented imports * fake controls * looking up actual controls for comparison. * adding key to test setup * controls inventory * apache junk * lint ✨ * ignore null controls * fixing goofed up spread operation for xAxisFormat config * lint ✨ * fixes for errors caused by <hr> element in filterbox controls * fixing filter controls for 'druid_time_origin', 'granularity', 'granularity_sqla', 'time_grain_sqla' * getControlsInventory -> getControlsForVizType * further renaming of chartControlsInventory - > getControlsForVizType Co-authored-by: David Aaron Suddjian <[email protected]> * fix: Add deprecated fields to QueryObject schema (#9579) * fix: Add deprecated fields to QueryObject schema * linting * [mypy] Enforcing typing for superset.migrations (#9583) Co-authored-by: John Bodley <[email protected]> * Re-enable the AnnotationLayerModelView read API (#9443) * Re-enable the AnnotationLayerModelView read API * Fix CI * [config] Enable dashboard bootstrap payload reduction by default (#9585) * [docs] fix, elastic.co elasticsearch product location (#9598) * [fix] Fixing issue with Jinja filter_value (#9582) Co-authored-by: John Bodley <[email protected]> * [Build] moves prettier check to separate script (#9591) * [Build] moves prettier check to separate script * rename step: eslint -> lint * Add documentation build to Github Actions (#9569) * Add documentation build to Github Actions * Update requirements for documentation builds * Minor optimization - only install requirements for documentation in documentation job * Add raw number/integer option to d3 number formats (#9562) * Bump superset-ui-connection to 0.12.22 (#9602) * [charts] feat: add statsd to charts api (#9571) * add statsd to charts api * update test for charts api * [charts] add statsd asserts wrapper * [charts] update api test * removed white space * [tests] Helper script to run single tests (#9547) * [charts] adds new filters ui (#9530) * [charts] adds new filters ui * move null check to be more visible * better filter lists and async filter functionality * [SQL Lab] Lock result set controls to be always visible (#9587) * improve helm chart * add Apache license headers * add initjob conf + secret * add missing headers * apply changes * opps again .... license Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Krist Wongsuphasawat <[email protected]> Co-authored-by: John Bodley <[email protected]> Co-authored-by: ʈᵃᵢ <[email protected]> Co-authored-by: Evan Rusackas <[email protected]> Co-authored-by: Maxime Beauchemin <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Will Barrett <[email protected]> Co-authored-by: Craig Rueda <[email protected]> Co-authored-by: Grace Guo <[email protected]> Co-authored-by: Jesse Yang <[email protected]> Co-authored-by: Alexander Mancevice <[email protected]> Co-authored-by: John Bodley <[email protected]> Co-authored-by: David Aaron Suddjian <[email protected]> Co-authored-by: venter <[email protected]> Co-authored-by: Naren <[email protected]> Co-authored-by: Luca Toscano <[email protected]> Co-authored-by: dandanhub <[email protected]> Co-authored-by: Dandan Shi <[email protected]> Co-authored-by: Bogdan <[email protected]> Co-authored-by: bogdan kyryliuk <[email protected]> Co-authored-by: Octavian <[email protected]> Co-authored-by: Aliaksei Kushniarevich <[email protected]> Co-authored-by: David Aaron Suddjian <[email protected]> Co-authored-by: Erik Ritter <[email protected]> Co-authored-by: Lily Kuang <[email protected]>
hughhhh
pushed a commit
that referenced
this issue
Jun 2, 2021
# This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases
hughhhh
pushed a commit
that referenced
this issue
Jun 3, 2021
# This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases
hughhhh
added a commit
that referenced
this issue
Jun 3, 2021
* split db modal file * split db modal file * hook up available databases * add comment * split db modal file * hook up available databases * use new validation component * first draft * use new validation component * get tests passing * split db modal file * hook up available databases * use new validation component * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * revisions * fix package-lock.json * # This is a combination of 6 commits. # This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases * fix test for db modal * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * more revisions * used db.backend * added engine to model * elizabeth revisions * elizabeth revisions Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: hughhhh <[email protected]>
hughhhh
pushed a commit
that referenced
this issue
Jun 4, 2021
# This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases
hughhhh
added a commit
that referenced
this issue
Jul 2, 2021
* split db modal file * split db modal file * hook up available databases * add comment * split db modal file * hook up available databases * use new validation component * first draft * use new validation component * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * get tests passing * Removed logo from test * split db modal file * hook up available databases * use new validation component * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * saving for now * revisions * fix package-lock.json * update styles * save * # This is a combination of 6 commits. # This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases * fix test for db modal * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * more revisions * create 1 function for setting the DB * add function to preferred section * small refactor and added styling * used db.backend * add new footer buttons * add finsh buttong * refactor db modal render * fix comments issue * added engine to model * elizabeth revisions * add header * add bottom footer to sqlalchemy form * # This is a combination of 6 commits. # This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases * fix test for db modal * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * elizabeth revisions * add back headers * add step * feat: Dynamic Form for edit DB Modal (#14845) * split db modal file * split db modal file * hook up available databases * add comment * split db modal file * hook up available databases * use new validation component * first draft * use new validation component * get tests passing * split db modal file * hook up available databases * use new validation component * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * revisions * fix package-lock.json * # This is a combination of 6 commits. # This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases * fix test for db modal * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * more revisions * used db.backend * added engine to model * elizabeth revisions * elizabeth revisions Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: hughhhh <[email protected]> * address comments * oops * # This is a combination of 6 commits. # This is the 1st commit message: feat: validation db modal (#14832) * split db modal file * hook up available databases * use new validation component # This is the commit message #2: feat: Icon Button (#14818) * Creating IconButton * Changed naming: logo is now icon * Hard-coded inset values for ellipses * Removed default SVG * Fixed test * Removed logo from test # This is the commit message #3: chore: Improves the native filters UI/UX - iteration 6 (#14932) # This is the commit message #4: fix: is_temporal should overwrite is_dttm (#14894) * fix: is_temporal should overwrite is_dttm * move up # This is the commit message #5: fix: time parser truncate to first day of year/month (#14945) # This is the commit message #6: hook up available databases * fix test for db modal * feat(db-connection-ui): Allow users to pick engine (#14884) * poc picker for db selection * working select * setup is loading for available dbs and step1 view * fix on close * update on fetch * remove unneeded code * add some styls * remove merge conflicts * small fix on blocking creating * feat(db-connection-ui): Big Query Add Database Form (#14829) * fix(native-filters): Manage default value of filters by superset (#14785) * fix:fix get permission function * feat: manage default value in superset * fix(native-filters): loop bug by simplify state handling (#14788) * fix: set table name width to not hide icons when name is too long (#14489) * fix: set table name width to now hide icons when name is too long * fix: table style Co-authored-by: einatnielsen <[email protected]> * feat(explore): Remove default for time range filter and Metrics (#14661) * feat(explore): Remove default for time range filter and Metrics * Merge errors with same messages * Fix e2e test * Rename a variable * Bump packages * Fix unit tests * feat: chart gallery search improvement (#14484) * feat: chart gallery search improvement * test: adding unit test for VizTypeControl * fix: lint errors Co-authored-by: einatnielsen <[email protected]> * Update schemas.py * Update bigquery.py * Fix tests * big query form is appearing on the screen * add name to allow for actions to get picked up * working post for saving db via paste * working file upload * switch to textare * better styles * add delete buttong * save formating * wrap encrypted_extra * formatting component * clear out file input before reloading * remove default driver * address comments * fix things off rebase * small refactore * more patches * checkout space file * fix variable ref Co-authored-by: simcha90 <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Einat Bertenthal <[email protected]> Co-authored-by: einatnielsen <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> * feat: adding SSL Toggle to Create Database Modal (#14976) * first draft of SSL Toggle * added payload data * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx Co-authored-by: Beto Dealmeida <[email protected]> * changed tooltips based on stephen advice Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> * feat(database-connection-ui) Allow configuration of Database Images from SupersetText (#15023) * saving this for now * fix some styles * add database images * fix * enforce only numbers * add default iamge * fix bug * additional params to the DatabaseConnectionForm (#15071) * additional params to the DatabaseConnectionForm * save passing params up to api * feat: Added Steps and centralized Headers (#15041) * fix superset_text issue (#15095) * fix edit issue by returning parameters properly (#15101) * feat: added alerts (#15103) * added alerts * revisions * fix: add icons (#15122) * added alerts * revisions * added icon * Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx Co-authored-by: AAfghahi <[email protected]> * fix: fixing api tests for database connections (#15124) * fixing api tests * added test for no config method on create * added config method to validation tests * fix(db-connection-ui): Additional Query Parameters render (#15150) * working query params * move condition out before update or create * fix type script issues * feat(db-connection-ui): Move fields from Extra section and split engine and metadata (#15143) * working edit extra options * acquired most of json * recontruct json * add schema array * add proper styles * fix tslint issues * remove console.log * this is working * style: Database connect UI Polish - Step 1 (#15119) * save avg * Styled step 1 * Remove Alert * Finished styling, added ellipsis library to IconButton * Fixed text margin Co-authored-by: hughhhh <[email protected]> * fix app from merge * fix tslint issues * fix all tslint issue on feature branch * catch errors for dialects with no driver set * fix dremio issue * fix dialect issue without driver attr * Styled step 3 (#15187) * feat: adding server-side validation and unmasked password on create (#15151) * fix: add icons (#15122) * added alerts * revisions * added icon * validation and password masking * revisions and validation range * revisions * added beto revisions * added tests for port range * added config to available * testing, rtl * made tests always pass * feat: add Close/Finish buttons to DBModal on Edit (#15199) * fix(db-connection-ui): Allow Dynamic Big Query Edits (#15185) * working big query edits * fix big stoping users from moving to next step * fix default * save defaults * fix tslint * remove object * fix styling * fix: Connect on DB Connection wasn't working (#15201) * fix: add icons (#15122) * added alerts * revisions * added icon * fixed the connect button * make available alphabetically sort * make available alphabetically sort II * fix selection * remove console.log * fix styling * fix: fix api_test and typeScript error (#15202) * fix big query issue * allow for query params * feat: Added Dynamic form link to SQL Alchemy Form (#15208) * fix: add icons (#15122) * added alerts * revisions * added icon * added dynamic form link * fix: fix api tests for test_available (#15210) * fix: add icons (#15122) * added alerts * revisions * added icon * fixes api tests * feat: added Spinner to DB Modal (#15229) * fix: add icons (#15122) * added alerts * revisions * added icon * spinner * Made header sticky (#15204) * fix: make Edit DB modal look similar to create Modal (#15231) * fix: add icons (#15122) * added alerts * revisions * added icon * spinner * changed edit * fix: DB Connection UI R2 Fixes (#15232) * fix display name refill * fix order of additional params to always be at the bottom * remove schema check on validation * make encryption last * fix json file upload * fix additional params issue * remove comments * add back validation * small fixes on bigquery edit * only wrap encrypted with bigquery * specific conditions for wrapping big query items * dix additional params * fix allow display name in sqlalchemy form * backend before engine * fix: do not use Marshmallow validation in partial params validation (#15236) * fix: do not use Marshmallow validation in partial params validation * Fix lint * Update test * make display name required * reset validation errors onClose (#15243) * fix: Edit for all dynamic forms (#15244) * fix edit for dynamic forms * fix linting * fix edit on sqlalchemy forms * fix big query reference * remove extra if * wrap configuration method (#15274) * add more specific engine elastic search (#15287) * do a deep copy of obj before POST (#15298) * feat: add Back button to extra options (#15300) * fix: add icons (#15122) * added alerts * revisions * added icon * spinner * first draft * working * added back button to create modal * revisions and testing * chore: Add tooltips and button to Connect Postgresql DB Modal Form (#15179) * Added tooltips. Still need to place in the right spot. * Revert to where I started. * Added 3 tooltips, 1 Button(need link config). BigQuery not added yet. * Added tooltip BigOuery modal. `span` above upload btn missing `*` * Added tooltip to `Host` field. Alignment needs to be fixed. * Stuck trying to add conditional render of tooltip to LabeledErrorBoundInput * Clean commit for review * Dynamic tooltip componet created. Needs alignment of SVG still. * Fixed typo. * Added line spacing back in * Changed required props to optional/Remove comment * Fixed alignment of tooltips & moved 2tooltips outside of Btn * Added one more line space back in * Removed Typo * Removed another typo * Flixed linter error * Created test for tooltip. * Added expectation for visible tooltipIcon Co-authored-by: andrewbastian <[email protected]> * style: Database Modal UI Polish (#15234) * Corrected polishing tasks from Clubhouse ticket * More UI polish * Added more polish * Moved encryption field and created constant value for viewBox in InfoToolTip * feat: allow editing (#15308) * fix: add icons (#15122) * added alerts * revisions * added icon * spinner * elizabeth fixed the edit issue * feat: Added error alert for DB connection Modal (#15242) * fix: add icons (#15122) * added alerts * revisions * added icon * spinner * added errorAlert * added revisions * current work * revisions * fix: validation on edit (#15310) * fix: Big Query Error messaging (#15334) * remove validation check * remove validation check * fix error messaging * stop validation on big query * add condition for skipping specific engines for validation * if no params * update styles * feat: big Query using back button (#15338) * fix: password errors on validation (#15372) * filter out password supply for validation * filter password * feat: updated Error Alert (#15377) * Updated styling (#15379) * fix password error filter * feat: Arash/password field error (#15388) * fix: Back Button on Create for DB conncetion (#15389) * fix: add icons (#15122) * added alerts * revisions * added icon * spinner * fixing backButton on Create * fix doc (#15393) * style: Database Connection Modal UI Polish R5 (#15412) * Fixed inconsistent header spacing in step 1 * Touched up tooltips * Added red *s to BigQuery form * Centered modal window * make alerts configurable (#15404) * fix: Allow users to override database connection docs (#15434) * allow users to override docs * fix linting issue * fix: Error Icon not showing up on errored input fieds on validation (#15431) * Fixed now-show error icon Signed-off-by: andrewbastian <[email protected]> * Changed `%` to `px` * Fixed lint error * Changed units to `theme.gridUnit` * test: RTL testing on DatabaseModal (#15394) * RTL testing on DatabaseModal * Continued RTL testing on DatabaseModal * Code cleanup * Removed a comment that missed my radar * test: Add e2e testing (#15376) * create boilerplate for cypress test * added 1 more test * add more test cases * saving this for development * lit * remove name * update pass * remove unused test * fix merge conflicts * Fixed "connetion" typo (#15458) * fix: Database connection modal touch up (#15463) * Removed unnecessary TODO and named the remaining ones * Added translation functionality * Fixed typo in Database Modal RTL test * Update modal.test.ts * fix: Showing errors for SQLA forms (#15462) * fix documentation links * fix sqlalchemy onCreate * Fixing SQLA error messaging * fix logic for extra save * fix this issue * fix: Update Invalid Port SIP-40 Reference (#15464) * Fixed jumpy header text * fix: Edit Modal not saving properly (#15468) * Aligned info icons on dynamic form * fix: merge conflict (#15479) * chore: simplify errors and issue codes (#15437) * Fix issue number * Fix test * Fixed line-height in header, also fixed translation functions in BigQuery * Updated placeholder text in additional params field * Fixed padding in edit form * Corrected placeholder text in BigQuery > Service Account field * Make linter happy Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: Arash <[email protected]> Co-authored-by: hughhhh <[email protected]> Co-authored-by: AAfghahi <[email protected]> Co-authored-by: simcha90 <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Einat Bertenthal <[email protected]> Co-authored-by: einatnielsen <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: Andrew Bastian <[email protected]> Co-authored-by: andrewbastian <[email protected]>
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this issue
Oct 4, 2021
zhaoyongjie
pushed a commit
that referenced
this issue
Nov 24, 2021
zhaoyongjie
pushed a commit
that referenced
this issue
Nov 24, 2021
* build: add commitlint and commitizen * docs: add section about commit message to readme * chore: 🤖 use streamich/git-cz for creating commit message
zhaoyongjie
pushed a commit
that referenced
this issue
Nov 25, 2021
zhaoyongjie
pushed a commit
that referenced
this issue
Nov 25, 2021
* build: add commitlint and commitizen * docs: add section about commit message to readme * chore: 🤖 use streamich/git-cz for creating commit message
zhaoyongjie
pushed a commit
that referenced
this issue
Nov 26, 2021
zhaoyongjie
pushed a commit
that referenced
this issue
Nov 26, 2021
* build: add commitlint and commitizen * docs: add section about commit message to readme * chore: 🤖 use streamich/git-cz for creating commit message
JakobMiksch
pushed a commit
to JakobMiksch/superset
that referenced
this issue
Jan 5, 2023
Update readme
ritwickdey
pushed a commit
to ritwickdey/superset
that referenced
this issue
Mar 9, 2023
feat: Added Indian number and currency formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
When I try to check my datasource
ValueError
ValueError: Query component: limit_spec is not valid for query type: groupBy.The list of valid components is:
['datasource', 'granularity', 'filter', 'aggregations', 'post_aggregations', 'intervals', 'dimensions']
The text was updated successfully, but these errors were encountered: