Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time Series Table: Difference calculation has wrong sign #3612

Closed
3 tasks done
rumbin opened this issue Oct 6, 2017 · 2 comments · Fixed by #3646
Closed
3 tasks done

Time Series Table: Difference calculation has wrong sign #3612

rumbin opened this issue Oct 6, 2017 · 2 comments · Fixed by #3646

Comments

@rumbin
Copy link
Contributor

rumbin commented Oct 6, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.20.3

Expected results

The calculated result of a Time Comparison → Difference column reflects the value change of the chosen time lag interval.

E.g., if the time lag is, say, one week and the value of the observed metric has decreased within the last week, then the sign of the calculated difference has to be negative.

Actual results

The sign of the calculated difference is twisted.

Example:
time_series_table_diff_bug

Steps to reproduce

E.g.:
time_filter_bug1

PS: @mistercrunch: Thanks for releasing 0.20.3 so quickly!
@mistercrunch
Copy link
Member

Addressed here: #3597

@rumbin
Copy link
Contributor Author

rumbin commented Oct 10, 2017

@mistercrunch Could you please revisit this issue?
I had a look at #3597 and don't see the diff calculation modified there.
I'm my understanding, v -= recent; needs to be changed to v = recent - v;.

@mistercrunch mistercrunch reopened this Oct 11, 2017
mistercrunch added a commit to mistercrunch/superset that referenced this issue Oct 11, 2017
@mistercrunch
Fix apache#3612 - reverse sign in difference calculation
cdd5374
@mistercrunch mistercrunch mentioned this issue Oct 11, 2017
Merged
mistercrunch added a commit that referenced this issue Oct 12, 2017
@mistercrunch
Fix #3612 - reverse sign in difference calculation (#3646)
3ebadbc
eddy-geek added a commit to eddy-geek/incubator-superset that referenced this issue Oct 15, 2017
@eddy-geek
Merge remote-tracking branch 'remotes/origin/master' into filter_inpu…
609d1e2 
…t_box

* remotes/origin/master: (340 commits)
  [New Viz] Partition Diagram (apache#3642)
  Add description for running specific test (apache#3665)
  Making the sort order for metrics pull from fd for time table viz (apache#3661)
  Make columns that return an exception on click unsortable. (apache#3417)
  Adding sort time table (apache#3651)
  added aihello as superset user. (apache#3647)
  Fix apache#3612 - reverse sign in difference calculation (apache#3646)
  Fixing some warnings during tests (apache#3648)
  [Translations] Restored lost French translations (apache#3645)
  [sql lab] fix impersonation + template issue (apache#3644)
  Pin moment.js library since 2.19.0 creates problem (apache#3641)
  [time_table] adding support for URLs / links (apache#3600)
  Set tooltip to show extent of sparkData (apache#3626)
  add explicit message display for 'Fetching Annotation Layer' error (apache#3631)
  [bugfix] Template rendering failed: '_AppCtxGlobals' object has no attribute 'user' (apache#3637)
  fix long title text wrapping in editable-title component (apache#3638)
  [minor] proper tooltip on ControlHeader's instant re-render trigger (apache#3625)
  add annotation option and a linear color map for heatmap viz. (apache#3634)
  [bugfix] empty From date filter NoneType error (apache#3633)
  remove unused imports (apache#3621)
  ...
michellethomas pushed a commit to michellethomas/panoramix that referenced this issue May 24, 2018
@mistercrunch @michellethomas
Fix apache#3612 - reverse sign in difference calculation (apache#3646)
42772e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3612 - reverse sign in difference calculation mistercrunch/superset
2 participants
@mistercrunch @rumbin