Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Panel not rendered correctly when datasource type is changed #3137

Closed
3 tasks done
FrederichCheng opened this issue Jul 16, 2017 · 0 comments
Closed
3 tasks done

Comments

@FrederichCheng
Copy link
Contributor

FrederichCheng commented Jul 16, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.18.5

Expected results

Control Panel should be rendered correctly with all the controls related to the target data source when users change the data source from one to another with a different data source type.

Actual results

Some sections have no controls and the following javascript error is shown:'
Uncaught TypeError: Cannot read property 'controlSetRows' of undefined at store.js:16 at Array.forEach (<anonymous>) at getControlNames (store.js:15) at getControlsState (store.js:47) at Object.RESET_FIELDS (exploreReducer.js:158) at exploreReducer (exploreReducer.js:166) at dispatch (createStore.js:165) at index.js:14 at dispatch (applyMiddleware.js:35) at Object.success (exploreActions.js:74)

Steps to reproduce

Change druid type data source to table type data source or vice versa.

FrederichCheng pushed a commit to FrederichCheng/incubator-superset that referenced this issue Jul 16, 2017
mistercrunch pushed a commit that referenced this issue Jul 17, 2017
FrederichCheng pushed a commit to FrederichCheng/incubator-superset that referenced this issue Aug 3, 2017
mistercrunch pushed a commit that referenced this issue Aug 4, 2017
* #3137 add the leftover code from #3138 for fixing issue #3137

* #3239 Use slice id as the key instead of sliceName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant