Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sankey dashboard tooltip far outside slice #1748

Closed
2 tasks done
ddol opened this issue Dec 2, 2016 · 1 comment
Closed
2 tasks done

Sankey dashboard tooltip far outside slice #1748

ddol opened this issue Dec 2, 2016 · 1 comment
Assignees
@ddol

Comments

@ddol
Copy link
Contributor

ddol commented Dec 2, 2016

If the Sankey Visualisation is not the first slice on a dashboard, the tooltip is misplaced, floating outside the frame:

screen shot 2016-12-02 at 11 54 11

  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.14.1

Expected results

Tooltip hovers over mouse

Actual results

Tooltip hovers far away from the mouse.

Steps to reproduce

Load the Misc Charts dashboard and hover over the Energy Sankey chart
ddol pushed a commit that referenced this issue Dec 2, 2016
Sankey Tooltip fix (#1748)
96b58b4
@ddol ddol mentioned this issue Dec 2, 2016
Merged
ddol pushed a commit that referenced this issue Dec 3, 2016
Sankey Tooltip fix (#1748)
a697ac1
ddol added a commit that referenced this issue Dec 3, 2016
@ddol
Sankey Tooltip fix (#1748) (#1750)
b045075 
.layer{X,Y} gives viewport offset, moved to node offset using .offset{X,Y}
@ddol ddol self-assigned this Dec 3, 2016
@ddol ddol added the tooltips label Dec 3, 2016
@ddol
Copy link
Contributor Author

ddol commented Dec 3, 2016

PR #1750 resolves this issue.

@ddol ddol closed this as completed Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddol ddol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddol