I want superset {im, ex}port to *fail* if unsuccessful
#16956
Labels
#bug
Bug report
Comments
|
I understand this behaviour is intentional (this happens multiple times, plus This would surely make my life writing a Puppet manifest easier! |
|
Hi @EBoisseauSierra I agree, are you willing to open a fix PR? |
|
of course (: ! I should draft something by the end of the week and I'll gladly ping you once the WIP PR is out. |
9 tasks
EBoisseauSierra
added a commit
to EBoisseauSierra/superset
that referenced
this issue
Oct 19, 2021
Bubble exception up when failing import or export During a CLI import or export of dashboards, if the process fails, the exception it caught and a simple message is sent to the logger. This makes that from a shell point of view, the script was successfull — cf. apache#16956. To prevent this, we want to ensure that the process exits with an error (i.e., a non-0 exit-code) should the export or import fail mid-flight. Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
dpgaspar
pushed a commit
that referenced
this issue
Oct 29, 2021
* Test that failing export or import is done properly For each CLI entry-point we will modify, we make sure that: - a failing process exits with a non-0 exit code, - an error is logged. Signed-off-by: Étienne Boisseau-Sierra <[email protected]> * Exit process with error if export/import failed Bubble exception up when failing import or export During a CLI import or export of dashboards, if the process fails, the exception it caught and a simple message is sent to the logger. This makes that from a shell point of view, the script was successfull — cf. #16956. To prevent this, we want to ensure that the process exits with an error (i.e., a non-0 exit-code) should the export or import fail mid-flight. Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
|
Closing as fixed by #16976 |
eschutho
pushed a commit
that referenced
this issue
Nov 17, 2021
* Test that failing export or import is done properly For each CLI entry-point we will modify, we make sure that: - a failing process exits with a non-0 exit code, - an error is logged. Signed-off-by: Étienne Boisseau-Sierra <[email protected]> * Exit process with error if export/import failed Bubble exception up when failing import or export During a CLI import or export of dashboards, if the process fails, the exception it caught and a simple message is sent to the logger. This makes that from a shell point of view, the script was successfull — cf. #16956. To prevent this, we want to ensure that the process exits with an error (i.e., a non-0 exit-code) should the export or import fail mid-flight. Signed-off-by: Étienne Boisseau-Sierra <[email protected]> (cherry picked from commit f0c0ef7)
AAfghahi
pushed a commit
that referenced
this issue
Jan 10, 2022
* Test that failing export or import is done properly For each CLI entry-point we will modify, we make sure that: - a failing process exits with a non-0 exit code, - an error is logged. Signed-off-by: Étienne Boisseau-Sierra <[email protected]> * Exit process with error if export/import failed Bubble exception up when failing import or export During a CLI import or export of dashboards, if the process fails, the exception it caught and a simple message is sent to the logger. This makes that from a shell point of view, the script was successfull — cf. #16956. To prevent this, we want to ensure that the process exits with an error (i.e., a non-0 exit-code) should the export or import fail mid-flight. Signed-off-by: Étienne Boisseau-Sierra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the import of a dashboard export fails, the logger lists an exception but the Python script exits as successful. This is a bit counter-intuitive as the import/export has actually failed.
How to reproduce the bug
except Exceptioncatch.0exit code.Expected results
Because the command has effectively failed to execute, I expect the Python script to exits with a non-0 exit code.
Actual results
0-exit code.
Environment
1.3.03.8.12"VERSION_EXPORT": TrueChecklist
Make sure to follow these steps before submitting your issue - thank you!
The text was updated successfully, but these errors were encountered: