Error creating Elasticsearch Dataset, raise NoSuchTable Exception

[aniaan]

Error creating Elasticsearch Dataset, raise NoSuchTable Exception

Expected results

create success

Actual results

create error

Screenshots

Environment

(please complete the following information):

docker: apache/superset:latest

• superset version: superset version
• python version: python --version
• node.js version: node -v
• any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

By troubleshooting, I found that the error occurs when I select ES-view (actually alias), and is created correctly if the real Index is selected.

superset/superset/connectors/sqla/utils.py

Lines 37 to 47 in 37c2020

	def get_physical_table_metadata(
	database: Database, table_name: str, schema_name: Optional[str] = None,
	) -> List[Dict[str, str]]:
	"""Use SQLAlchemy inspector to get table metadata"""
	db_engine_spec = database.db_engine_spec
	db_dialect = database.get_dialect()
	# ensure empty schema
	_schema_name = schema_name if schema_name else None
	# Table does not exist or is not visible to a connection.
	if not database.has_table_by_name(table_name, schema=_schema_name):
	raise NoSuchTableError

Here the check of whether the table_name exists in the schema is performed, without considering the case when table_name=view, the check here should be table_name in tables or table_name in views

cc: @junlincc @zhaoyongjie

traceback

Traceback (most recent call last):
File "/app/superset/datasets/commands/create.py", line 51, in run
dataset.fetch_metadata(commit=False)
File "/app/superset/connectors/sqla/models.py", line 1499, in fetch_metadata
new_columns = self.external_metadata()
File "/app/superset/connectors/sqla/models.py", line 663, in external_metadata
database=self.database, table_name=self.table_name, schema_name=self.schema,
File "/app/superset/connectors/sqla/utils.py", line 47, in get_physical_table_metadata
raise NoSuchTableError
sqlalchemy.exc.NoSuchTableError: ()
2021-09-07 23:39:39,426:WARNING:superset.datasets.commands.create:()
Traceback (most recent call last):
File "/app/superset/datasets/commands/create.py", line 51, in run
dataset.fetch_metadata(commit=False)
File "/app/superset/connectors/sqla/models.py", line 1499, in fetch_metadata
new_columns = self.external_metadata()
File "/app/superset/connectors/sqla/models.py", line 663, in external_metadata
database=self.database, table_name=self.table_name, schema_name=self.schema,
File "/app/superset/connectors/sqla/utils.py", line 47, in get_physical_table_metadata
raise NoSuchTableError
sqlalchemy.exc.NoSuchTableError: ()
Error creating model DatasetRestApi: Dataset could not be created.
Traceback (most recent call last):
File "/app/superset/datasets/commands/create.py", line 51, in run
dataset.fetch_metadata(commit=False)
File "/app/superset/connectors/sqla/models.py", line 1499, in fetch_metadata
new_columns = self.external_metadata()
File "/app/superset/connectors/sqla/models.py", line 663, in external_metadata
database=self.database, table_name=self.table_name, schema_name=self.schema,
File "/app/superset/connectors/sqla/utils.py", line 47, in get_physical_table_metadata
raise NoSuchTableError
sqlalchemy.exc.NoSuchTableError: ()
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/app/superset/datasets/api.py", line 251, in post
new_model = CreateDatasetCommand(g.user, item).run()
File "/app/superset/datasets/commands/create.py", line 65, in run
raise DatasetCreateFailedError() from ex
superset.datasets.commands.exceptions.DatasetCreateFailedError: Dataset could not be created.
2021-09-07 23:39:39,428:ERROR:superset.datasets.api:Error creating model DatasetRestApi: Dataset could not be created.
Traceback (most recent call last):
File "/app/superset/datasets/commands/create.py", line 51, in run
dataset.fetch_metadata(commit=False)
File "/app/superset/connectors/sqla/models.py", line 1499, in fetch_metadata
new_columns = self.external_metadata()
File "/app/superset/connectors/sqla/models.py", line 663, in external_metadata
database=self.database, table_name=self.table_name, schema_name=self.schema,
File "/app/superset/connectors/sqla/utils.py", line 47, in get_physical_table_metadata
raise NoSuchTableError
sqlalchemy.exc.NoSuchTableError: ()
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/app/superset/datasets/api.py", line 251, in post
new_model = CreateDatasetCommand(g.user, item).run()
File "/app/superset/datasets/commands/create.py", line 65, in run
raise DatasetCreateFailedError() from ex