Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmetic][dashboard] Expanding three dots on filter box is rendered behind, not all options visible #12108

Closed
2 of 3 tasks
zuzana-vej opened this issue Dec 18, 2020 · 5 comments
Assignees
Labels
dashboard:native-filters Related to the native filters of the Dashboard !deprecated-label:bug Deprecated label - Use #bug instead

Comments

@zuzana-vej
Copy link
Contributor

zuzana-vej commented Dec 18, 2020

Cosmetic issue (regression) - when you click the three dots on a smaller filter box, the popup with list of options renders in the background (inside the filter box component) instead of over (previous behavior) meaning it's hard for user to select their action. This is especially visible on the filter box, (could be in small charts too in theory).

Expected results

Render over so that all options are visible

Actual results

renders behind (lilmited to filter box size)

Screenshots

fikter-box-cosmetic
filter-box-cosmetic

How to reproduce the bug

  1. Create a small (in terms of height) filter box
  2. Click on the three dots
  3. See issue

Environment

(please complete the following information):

  • superset version: master
  • python version: python --version
  • node.js version: node -v

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Regression

@zuzana-vej zuzana-vej added the !deprecated-label:bug Deprecated label - Use #bug instead label Dec 18, 2020
@zuzana-vej
Copy link
Contributor Author

This one is certainly low priority, probably introduced together with #12107 and #12105

@zuzana-vej zuzana-vej added the dashboard:native-filters Related to the native filters of the Dashboard label Dec 18, 2020
@zuzana-vej zuzana-vej changed the title Cosmetic: Expanding three dots on filter box is rendered behind, not all options visible [cosmetic][dashboard] Expanding three dots on filter box is rendered behind, not all options visible Dec 18, 2020
@rusackas
Copy link
Member

rusackas commented Dec 18, 2020

I think I see what's happening here... in SliceHeaderControls.jsx you can see that AntD's getPopupContainer is used to render the Dropdown within the chart, where it used to be rendered in the body (the default behavior). This was done to for taking a screenshot of the viz (with the "download as image" menu item) which would hide the menu, take the screenshot, and show the menu again. This took place in https://github.com/apache/incubator-superset/pulls/11778

CCing for context: @kgabryje @nikolagigic @geido @maloun96

@kgabryje
Copy link
Member

Most likely it's caused by visibilty: hidden in 1 of Antd's components. Overriding it to visible should do the trick. I can take a look once I'm done with tasks related to explore redesign

@maloun96
Copy link
Contributor

#12108

@zuzana-vej
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:native-filters Related to the native filters of the Dashboard !deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

5 participants