address comments

apache · Jun 8, 2022 · fe5be22 · fe5be22
1 parent 001e8c0
commit fe5be22
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx b/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx
@@ -205,8 +205,8 @@ export const DataTablesPane = ({
     if (idx > 0) {
       return (
         <Tabs.TabPane
-          tab={t('Results %s', idx)}
-          key={`${ResultTypes.Results} ${idx}`}
+          tab={t('Results %s', idx + 1)}
+          key={`${ResultTypes.Results} ${idx + 1}`}
         >
           {pane}
         </Tabs.TabPane>

diff --git a/...rset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx b/...rset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx
@@ -57,8 +57,8 @@ export const ResultsPaneOnDashboard = ({
 
     return (
       <Tabs.TabPane
-        tab={t('Results %s', idx)}
-        key={`${ResultTypes.Results} ${idx}`}
+        tab={t('Results %s', idx + 1)}
+        key={`${ResultTypes.Results} ${idx + 1}`}
       >
         {pane}
       </Tabs.TabPane>

diff --git a/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx b/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx
@@ -155,6 +155,6 @@ describe('ResultsPaneOnDashboard', () => {
       useRedux: true,
     });
     expect(await findByText('Results')).toBeVisible();
-    expect(await findByText('Results 1')).toBeVisible();
+    expect(await findByText('Results 2')).toBeVisible();
   });
 });