remove extra onClick and make disabled prop optional

apache · Dec 1, 2021 · eca9815 · eca9815
1 parent 511b4b8
commit eca9815
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx b/superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
@@ -33,7 +33,7 @@ interface EstimateQueryCostButtonProps {
   queryCostEstimate: Record<string, any>;
   selectedText?: string;
   tooltip?: string;
-  disabled: boolean;
+  disabled?: boolean;
 }
 
 const EstimateQueryCostButton = ({
@@ -56,10 +56,6 @@ const EstimateQueryCostButton = ({
     [cost],
   );
 
-  const onClick = () => {
-    getEstimate();
-  };
-
   const renderModalBody = () => {
     if (queryCostEstimate.error !== null) {
       return (
@@ -95,7 +91,7 @@ const EstimateQueryCostButton = ({
         triggerNode={
           <Button
             style={{ height: 32, padding: '4px 15px' }}
-            onClick={onClick}
+            onClick={getEstimate()}
             key="query-estimate-btn"
             tooltip={tooltip}
             disabled={disabled}