Fix applied value

apache · Mar 25, 2024 · e448a3e · e448a3e
1 parent a30cc7c
commit e448a3e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx b/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
@@ -509,7 +509,7 @@ class AnnotationLayer extends React.PureComponent {
   }
 
   applyAnnotation() {
-    const { value } = this.state;
+    const { value, sourceType } = this.state;
     if (this.isValidForm()) {
       const annotationFields = [
         'name',
@@ -536,8 +536,9 @@ class AnnotationLayer extends React.PureComponent {
         }
       });
 
-      // Set value to id of annotation for use in runAnnotationQuery()
-      newAnnotation.value = value.value;
+      // Prepare newAnnotation.value for use in runAnnotationQuery()
+      const applicableValue = requiresQuery(sourceType) ? value.value : value;
+      newAnnotation.value = applicableValue;
 
       if (newAnnotation.color === AUTOMATIC_COLOR) {
         newAnnotation.color = null;