fix(explore): make SORT-Descending visible if Sort-by has value (#17726)

apache · Dec 21, 2021 · d5768ab · d5768ab
1 parent 5b0aa27
commit d5768ab
Show file tree

Hide file tree

Showing 16 changed files with 32 additions and 0 deletions.
diff --git a/superset-frontend/plugins/legacy-plugin-chart-horizon/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-horizon/src/controlPanel.ts
@@ -42,6 +42,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
           {

diff --git a/superset-frontend/plugins/legacy-plugin-chart-paired-t-test/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-paired-t-test/src/controlPanel.ts
@@ -45,6 +45,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
           {

diff --git a/superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates/src/controlPanel.ts
@@ -40,6 +40,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx b/superset-frontend/plugins/legacy-plugin-chart-partition/src/controlPanel.tsx
@@ -48,6 +48,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
           {

diff --git a/superset-frontend/plugins/legacy-plugin-chart-pivot-table/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-pivot-table/src/controlPanel.ts
@@ -47,6 +47,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx b/superset-frontend/plugins/legacy-plugin-chart-rose/src/controlPanel.tsx
@@ -46,6 +46,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
           {

diff --git a/superset-frontend/plugins/legacy-plugin-chart-treemap/src/controlPanel.ts b/superset-frontend/plugins/legacy-plugin-chart-treemap/src/controlPanel.ts
@@ -44,6 +44,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts
@@ -59,6 +59,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx
@@ -354,6 +354,8 @@ export const timeSeriesSection: ControlPanelSectionConfig[] = [
             label: t('Sort Descending'),
             default: true,
             description: t('Whether to sort descending or ascending'),
+            visibility: ({ controls }) =>
+              Boolean(controls?.timeseries_limit_metric.value),
           },
         },
       ],

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/controlPanel.tsx
@@ -89,6 +89,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
@@ -86,6 +86,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/...set-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx b/...set-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Scatter/controlPanel.tsx
@@ -66,6 +66,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/controlPanel.tsx
@@ -83,6 +83,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Step/controlPanel.tsx
@@ -89,6 +89,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/controlPanel.tsx
@@ -90,6 +90,8 @@ const config: ControlPanelConfig = {
               label: t('Sort Descending'),
               default: true,
               description: t('Whether to sort descending or ascending'),
+              visibility: ({ controls }) =>
+                Boolean(controls?.timeseries_limit_metric.value),
             },
           },
         ],

diff --git a/superset-frontend/src/explore/controlPanels/sections.tsx b/superset-frontend/src/explore/controlPanels/sections.tsx
@@ -125,6 +125,8 @@ export const NVD3TimeSeries: ControlPanelSectionConfig[] = [
             label: t('Sort descending'),
             default: true,
             description: t('Whether to sort descending or ascending'),
+            visibility: ({ controls }) =>
+              Boolean(controls?.timeseries_limit_metric.value),
           },
         },
         {