[line] improve feature (#4363)

Require Since and Until parameter as they are needed to time shift
apache · Feb 7, 2018 · c4eba9e · c4eba9e
1 parent 90d9616
commit c4eba9e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/superset/viz.py b/superset/viz.py
@@ -1073,6 +1073,11 @@ def get_data(self, df):
             delta = utils.parse_human_timedelta(time_compare)
             query_object['inner_from_dttm'] = query_object['from_dttm']
             query_object['inner_to_dttm'] = query_object['to_dttm']
+
+            if not query_object['from_dttm'] or not query_object['to_dttm']:
+                raise Exception(_(
+                    '`Since` and `Until` time bounds should be specified '
+                    'when using the `Time Shift` feature.'))
             query_object['from_dttm'] -= delta
             query_object['to_dttm'] -= delta