Skip to content

Commit

Permalink
fix(explore): make to convert null to N/A in view results (#19316)
Browse files Browse the repository at this point in the history
* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter

(cherry picked from commit 468c5ca)
  • Loading branch information
prosdev0107 authored and villebro committed Apr 3, 2022
1 parent 52f9b71 commit baeb36f
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
5 changes: 5 additions & 0 deletions superset-frontend/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,8 @@ export const FAST_DEBOUNCE = 250;
* Slower debounce delay for inputs with expensive API calls.
*/
export const SLOW_DEBOUNCE = 500;

/**
* Display null as `N/A`
*/
export const NULL_DISPLAY = 'N/A';
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {
BOOL_FALSE_DISPLAY,
BOOL_TRUE_DISPLAY,
SLOW_DEBOUNCE,
NULL_DISPLAY,
} from 'src/constants';
import { Radio } from 'src/components/Radio';
import Icons from 'src/components/Icons';
Expand All @@ -49,6 +50,10 @@ import {
unsetTimeFormattedColumn,
} from 'src/explore/actions/exploreActions';

export const CellNull = styled('span')`
color: ${({ theme }) => theme.colors.grayscale.light1};
`;

export const CopyButton = styled(Button)`
font-size: ${({ theme }) => theme.typography.sizes.s}px;
Expand Down Expand Up @@ -303,6 +308,9 @@ export const useTableColumns = (
if (value === false) {
return BOOL_FALSE_DISPLAY;
}
if (value === null) {
return <CellNull>{NULL_DISPLAY}</CellNull>;
}
if (timeFormattedColumnIndex > -1) {
return timeFormatter(value);
}
Expand Down

0 comments on commit baeb36f

Please sign in to comment.