Skip to content

Commit

Permalink
[bugfix] show results in query history & revert #5848 (#6436)
Browse files Browse the repository at this point in the history
* revert 848

* nit

(cherry picked from commit b1dbd1c)
  • Loading branch information
youngyjd authored and michellethomas committed Jan 14, 2019
1 parent 2521587 commit b9bcbb4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion superset/assets/src/SqlLab/components/QueryAutoRefresh.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class QueryAutoRefresh extends React.PureComponent {
return (
queriesLastUpdate > 0 &&
Object.values(queries).some(
q => ['running', 'started', 'pending', 'fetching', 'rendering'].indexOf(q.state) >= 0 &&
q => ['running', 'started', 'pending', 'fetching'].indexOf(q.state) >= 0 &&
now - q.startDttm < MAX_QUERY_AGE_TO_POLL,
)
);
Expand Down
1 change: 0 additions & 1 deletion superset/assets/src/SqlLab/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export const STATE_BSSTYLE_MAP = {
fetching: 'info',
running: 'warning',
stopped: 'danger',
rendering: 'info',
success: 'success',
};

Expand Down
2 changes: 1 addition & 1 deletion superset/assets/src/SqlLab/reducers/sqlLab.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export default function sqlLabReducer(state = {}, action) {
progress: 100,
results: action.results,
rows,
state: 'rendering',
state: 'success',
errorMessage: null,
cached: false,
};
Expand Down

0 comments on commit b9bcbb4

Please sign in to comment.